fix(interactive): Align Data Type in GIE Physical Pb with Flex #4367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shirly121
changed the title
|
Please check the preview of the documentation changes at |
Committed-by: xiaolei.zl from Dev container
Committed-by: [email protected] from Dev container
Committed-by: [email protected] from Dev container
Committed-by: [email protected] from Dev container
Committed-by: [email protected] from Dev container
Committed-by: [email protected] from Dev container
|
@longbinlai @shirly121 We need to make sure the cypher procedure is still callable with the changes in this PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4367 +/- ##
=======================================
Coverage ? 58.78%
=======================================
Files ? 12
Lines ? 592
Branches ? 0
=======================================
Hits ? 348
Misses ? 244
Partials ? 0 Continue to review full report in Codecov by Sentry.
|
This reverts commit 72c5eb5.
Committed-by: [email protected] from Dev container Committed-by: [email protected] from Dev container
Committed-by: [email protected] from Dev container
… proto Committed-by: bingqing.lbq from Dev container
Committed-by: bingqing.lbq from Dev container
Committed-by: [email protected] from Dev container Committed-by: [email protected] from Dev container
… into ir_align_type
BingqingLyu
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
a. Groot: defined in proto
b. Flex: defined in proto
c. Calcite, defined in java
The Calcite type system serves as the foundation for type inference in the compiler. Consequently, any other type system (e.g., Groot or Flex) must be convertible to Calcite.
The IrDataTypeConvertor plays a key role in this process. It defines the bidirectional type conversions between Calcite and the other two type systems.
Related issue number
Fixes #4362