Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(interactive): Add helm chart for Interactive #3387

Merged
merged 8 commits into from
Dec 19, 2023

Conversation

zhanglei1949
Copy link
Collaborator

@zhanglei1949 zhanglei1949 commented Nov 30, 2023

With the GraphScope Interactive helm chart, users can easily deploy an Interactive service on a k8s cluster.

Fix #3386

Other Modification:

  • InteractiveServer Itself will not init the default builtin graph. The builtin graph is loaded before InteractiveServer starts.

@zhanglei1949 zhanglei1949 marked this pull request as draft November 30, 2023 03:23
@codecov-commenter
Copy link

codecov-commenter commented Dec 1, 2023

Codecov Report

Merging #3387 (f117f27) into main (10ecb95) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3387   +/-   ##
=======================================
  Coverage   40.90%   40.90%           
=======================================
  Files         109      109           
  Lines       11343    11343           
=======================================
  Hits         4640     4640           
  Misses       6703     6703           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10ecb95...f117f27. Read the comment docs.

@zhanglei1949 zhanglei1949 marked this pull request as ready for review December 19, 2023 09:44
can launch, todo: test and make service on

add readme and container running script

refactor binary

stash

loading the builtin graph

f

stash the interactive

stash changes

support query on modern graph

finish implementation
siyuan0322
siyuan0322 previously approved these changes Dec 19, 2023
Copy link
Collaborator

@siyuan0322 siyuan0322 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, better cleanup those debug info, like the image tag.

@zhanglei1949 zhanglei1949 changed the title feat(Interactive): Add helm chart for Interactive feat(interactive): Add helm chart for Interactive Dec 19, 2023
shirly121
shirly121 previously approved these changes Dec 19, 2023
shirly121
shirly121 previously approved these changes Dec 19, 2023
@zhanglei1949 zhanglei1949 merged commit 15d603c into alibaba:main Dec 19, 2023
44 of 45 checks passed
@zhanglei1949 zhanglei1949 deleted the helm-deploy branch May 29, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(interactive): Cloud native deployment
4 participants