Fix biome tag checks, add test case for cold biome tags. Fixes #52

alcatrazEscapee · Jun 20, 2020 · 6f8409c · 6f8409c
1 parent 0416e49
commit 6f8409c
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/src/main/java/com/alcatrazescapee/oreveins/world/rule/BiomeRule.java b/src/main/java/com/alcatrazescapee/oreveins/world/rule/BiomeRule.java
@@ -9,6 +9,7 @@
 
 import com.google.gson.JsonObject;
 import com.google.gson.JsonParseException;
+import net.minecraft.util.JSONUtils;
 import net.minecraft.util.ResourceLocation;
 import net.minecraft.world.biome.Biome;
 import net.minecraftforge.common.BiomeDictionary;
@@ -35,7 +36,7 @@ protected BiomeRule createSingleRule(JsonObject json, String typeName)
         {
             if ("tag".equals(typeName))
             {
-                final BiomeDictionary.Type type = BiomeDictionary.Type.getType(typeName);
+                final BiomeDictionary.Type type = BiomeDictionary.Type.getType(JSONUtils.getString(json, "biomes"));
                 return biome -> BiomeDictionary.getTypes(biome).contains(type);
             }
             else if ("biome".equals(typeName))

diff --git a/src/main/resources/data/oreveins/oreveins/tests/test_biomes_tag_cold.json b/src/main/resources/data/oreveins/oreveins/tests/test_biomes_tag_cold.json
@@ -0,0 +1,12 @@
+{
+  "type": "sphere",
+  "stone": "minecraft:air",
+  "ore": "minecraft:black_concrete",
+  "rarity": 10,
+  "max_y": 100,
+  "min_y": 60,
+  "biomes": {
+    "type": "tag",
+    "biomes": "cold"
+  }
+}