-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version boosted to 2.0.3 #2329
Version boosted to 2.0.3 #2329
Conversation
Reviewer's Guide by SourceryThe version of the library was bumped to 2.0.3. The default value of the roughness parameter in PlasmaBrightnessContrast and PlasmaShadow transforms was changed to 3.0, and the description of the parameter was updated to reflect the change. The generate_plasma_pattern function now requires the roughness and random_generator parameters to be passed in. Class diagram showing changes to PlasmaBrightnessContrast and PlasmaShadow transformsclassDiagram
class ImageOnlyTransform
class PlasmaBrightnessContrast {
+roughness: float
note for PlasmaBrightnessContrast "roughness default changed from 0.5 to 3.0
Low values (< 1.0): Smoother pattern
Medium values (~2.0): Natural pattern
High values (> 3.0): Rough pattern"
}
class PlasmaShadow {
+roughness: float
note for PlasmaShadow "roughness default changed from 0.5 to 3.0
Low values (< 1.0): Smoother shadows
Medium values (~2.0): Natural shadows
High values (> 3.0): Rough shadows"
}
ImageOnlyTransform <|-- PlasmaBrightnessContrast
ImageOnlyTransform <|-- PlasmaShadow
Class diagram showing changes to generate_plasma_pattern functionclassDiagram
class generate_plasma_pattern {
+target_shape: tuple[int, int]
+roughness: float
+random_generator: np.random.Generator
note for generate_plasma_pattern "Parameters roughness and random_generator
are now required (removed default values)"
}
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ternaus - I've reviewed your changes - here's some feedback:
Overall Comments:
- This PR contains breaking changes (removal of default parameters in generate_plasma_pattern) but only bumps the patch version. According to semantic versioning, breaking changes require a major version bump. Please either revert the breaking changes or update to an appropriate version number.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Summary by Sourcery
Enhancements:
roughness
parameter in thePlasmaBrightnessContrast
andPlasmaShadow
augmentations to better align with user expectations.