Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VirtualRenderer): fix scrollbar overlap on autocompletion #5713

Merged
merged 5 commits into from
Jan 20, 2025
Merged

fix(VirtualRenderer): fix scrollbar overlap on autocompletion #5713

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e17e860
fix(virtual-renderer): fix toolbar overlap after changing content
xyos Jan 8, 2025
e0a9ded
test(VirtualRenderer): add tests for scrollbar changes
xyos Jan 15, 2025
68ceb91
Revert "fix(virtual-renderer): fix toolbar overlap after changing con…
xyos Jan 20, 2025
b67fa2e
fix(virtual-renderer): fix toolbar overlap after changing content
xyos Jan 20, 2025
b3def7f
test(VirtualRenderer): update virtualrenderer test
xyos Jan 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/virtual_renderer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1090,6 +1090,9 @@ class VirtualRenderer {
* @returns {number}
*/
$computeLayerConfig() {
// autosize is needed on the top to ensure accurate size calculations before hideScrollbars
if (this.$maxLines && this.lineHeight > 1)
this.$autosize();
var session = this.session;
var size = this.$size;

Expand All @@ -1107,10 +1110,7 @@ class VirtualRenderer {
this.$horizScroll = horizScroll;
this.scrollBarH.setVisible(horizScroll);
}
var vScrollBefore = this.$vScroll; // autosize can change vscroll value in which case we need to update longestLine
// autoresize only after updating hscroll to include scrollbar height in desired height
if (this.$maxLines && this.lineHeight > 1)
this.$autosize();
var vScrollBefore = this.$vScroll;

var minHeight = size.scrollerHeight + this.lineHeight;

Expand Down
Loading