refactor: validate ForceNew fields in ResourceDataSet #2038
+1,233
−102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byashimov
force-pushed
the
byashimov-NEX-508-validate-force-new
branch
3 times, most recently
from
305d59b to
02890f0
Compare
byashimov
force-pushed
the
byashimov-NEX-508-validate-force-new
branch
2 times, most recently
from
67b39b4 to
5eeafe7
Compare
byashimov
force-pushed
the
byashimov-NEX-508-validate-force-new
branch
2 times, most recently
from
6de426c to
aa35ffe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
import(ReadContext) doesn't setForceNewfield,terraform then compares "empty" value with the value from the config,
and outputs "replace" plan.
ResourceDataSetmust validate that given DTO has all requiredForceNewfields set.