feat(resource): add aiven_kafka_native_acl resource #1905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This has been developed against local version of go-client-codegen thus will fail until support has been merged there and right version has been updated to be used here. |
roope-kar
force-pushed
the
rkar-add-kafka-native-acls
branch
5 times, most recently
from
3ed8848 to
371c3b5
Compare
byashimov
reviewed
Nov 19, 2024
roope-kar
force-pushed
the
rkar-add-kafka-native-acls
branch
from
371c3b5 to
c419883
Compare
|
@byashimov Thanks for the review, comments resolved. |
roope-kar
force-pushed
the
rkar-add-kafka-native-acls
branch
2 times, most recently
from
ed896e6 to
5bfbaa7
Compare
roope-kar
force-pushed
the
rkar-add-kafka-native-acls
branch
from
5bfbaa7 to
853cfcd
Compare
roope-kar
force-pushed
the
rkar-add-kafka-native-acls
branch
from
853cfcd to
db8a0ca
Compare
rriski
previously requested changes
Dec 5, 2024
|
@rriski If ok, I can commit these as a follow up so we don't need to rerun acceptance tests 👍🏼 |
|
@roope-kar just rebase it. Won't affect tests. Which are green, btw :) |
roope-kar
force-pushed
the
rkar-add-kafka-native-acls
branch
from
db8a0ca to
da004b1
Compare
support managing aiven_kafka_native_acls.
roope-kar
force-pushed
the
rkar-add-kafka-native-acls
branch
from
da004b1 to
44634ff
Compare
|
@rriski @byashimov Thanks again for the review and help 🎉 Comments resolved 👍🏼 |
byashimov
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support managing aiven_kafka_native_acls.
About this change—what it does
Adds new resource for managing aiven_kafka_native_acls.
Why this way
So users can manage kafka native acls.