Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add disaster_recovery integration type #1867

Merged
merged 5 commits into from
Dec 12, 2024
Merged

feat: add disaster_recovery integration type #1867

merged 5 commits into from
Dec 12, 2024

Conversation

byashimov
Copy link
Contributor

@byashimov byashimov commented Oct 14, 2024 •
edited
Loading

  • Adds disaster_recovery service integration type support
  • Turns service_integrations into type set, so the order doesn't matter for future types
  • Removes custom service_integrations on aiven_clickhouse schema
  • Improves documentation: mentions only supported integrations types for each service type
  • Adds integration types validation

@byashimov byashimov force-pushed the byashimov-add-disaster-recovery-support branch from dbbfd9a to a4ecd64 Compare October 14, 2024 07:49
@byashimov byashimov force-pushed the byashimov-add-disaster-recovery-support branch 14 times, most recently from 02b2ec2 to 1a668df Compare December 4, 2024 17:36
@byashimov byashimov force-pushed the byashimov-add-disaster-recovery-support branch from 1a668df to 5863821 Compare December 4, 2024 18:03
@byashimov
Copy link
Contributor Author

tests

@byashimov byashimov marked this pull request as ready for review December 5, 2024 10:06
@byashimov byashimov requested a review from a team as a code owner December 5, 2024 10:06
@byashimov byashimov force-pushed the byashimov-add-disaster-recovery-support branch 3 times, most recently from f824a38 to 01ff219 Compare December 5, 2024 20:55
@byashimov byashimov marked this pull request as draft December 9, 2024 15:44
@byashimov byashimov force-pushed the byashimov-add-disaster-recovery-support branch from 01ff219 to 6d81aaa Compare December 10, 2024 10:16
@byashimov
refactor(clickhouse): remove service integration schema
453a93e 
Should be inherited from the common schema.
@byashimov
refactor: turn service integrations into set
a231b38 
The order doesn't matter for this field.
@byashimov
feat: add disaster_recovery integration type
7701ed6
@byashimov
feat: add integration types validation
69924d6 
Service integrations field gets only allowed integration types (from the API),
like `read_replica` or `disaster_recovery`.
Most of service types just do not support those integrations,
hence, it shouldn't be even possible to set them.
@byashimov byashimov force-pushed the byashimov-add-disaster-recovery-support branch from 6d81aaa to 69924d6 Compare December 11, 2024 10:29
@byashimov byashimov marked this pull request as ready for review December 12, 2024 10:55
@byashimov byashimov enabled auto-merge (squash) December 12, 2024 10:55
@byashimov byashimov merged commit 6d483c1 into main Dec 12, 2024
10 checks passed
@byashimov byashimov deleted the byashimov-add-disaster-recovery-support branch December 12, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rriski rriski rriski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@byashimov @rriski