Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #2876

Closed
wants to merge 1 commit into from
Closed

Update README.md #2876

wants to merge 1 commit into from

Conversation

omchaudhary1220
Copy link

Added the need of comments in the JavaScript code.

Copy link
Collaborator

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m not really sure what value this adds, can you explain?

@omchaudhary1220
Copy link
Author

omchaudhary1220 commented Dec 28, 2023 via email

@ljharb
Copy link
Collaborator

ljharb commented Dec 28, 2023

ok, but not only isn’t that the reason we make comments, it’s not what this section is for.

While the contribution is appreciated, generally speaking you should contribute to fix a problem you have, not just for the sake of contributing.

@ljharb ljharb closed this Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants