Skip to content

Commit

Permalink
fix some ci enhancement (#435)
Browse files Browse the repository at this point in the history
* fix(release): customize goreleaser config file, by adding json schema and fixing configuration version

* fix(go): rename invalid comment format

* fix(ci): made release workflow work again

replace goreleaser --rm-dist flag by --clean
increment go version for release pipeline
fetch previous tags use by goreleaser
give release workflow content write permissions to publish release
  • Loading branch information
RouxAntoine authored Jan 7, 2025
1 parent 561793c commit 0bcd0d5
Show file tree
Hide file tree
Showing 5 changed files with 12 additions and 5 deletions.
7 changes: 5 additions & 2 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,14 +19,17 @@ on:
- 'v*.*.*'
jobs:
goreleaser:
permissions:
contents: write
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@master
- run: git fetch --tags
- name: Setup Go
uses: actions/setup-go@v2
with:
go-version: '1.20'
go-version: '1.22'
- name: Install Snapcraft
uses: samuelmeuli/action-snapcraft@v1
- name: Setup Snapcraft
Expand All @@ -38,7 +41,7 @@ jobs:
uses: goreleaser/goreleaser-action@v2
with:
version: latest
args: release --rm-dist
args: release --clean
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- name: Update new version for plugin 'ctx' in krew-index
Expand Down
4 changes: 4 additions & 0 deletions .goreleaser.yml
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# yaml-language-server: $schema=https://goreleaser.com/static/schema.json

# Copyright 2021 Google LLC
#
# Licensed under the Apache License, Version 2.0 (the "License");
Expand All @@ -14,6 +16,8 @@

# This is an example goreleaser.yaml file with some sane defaults.
# Make sure to check the documentation at http://goreleaser.com

version: 2
before:
hooks:
- go mod download
Expand Down
2 changes: 1 addition & 1 deletion cmd/kubectx/version.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ var (
version = "v0.0.0+unknown" // populated by goreleaser
)

// VersionOps describes printing version string.
// VersionOp describes printing version string.
type VersionOp struct{}

func (_ VersionOp) Run(stdout, _ io.Writer) error {
Expand Down
2 changes: 1 addition & 1 deletion cmd/kubens/version.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ var (
version = "v0.0.0+unknown" // populated by goreleaser
)

// VersionOps describes printing version string.
// VersionOp describes printing version string.
type VersionOp struct{}

func (_ VersionOp) Run(stdout, _ io.Writer) error {
Expand Down
2 changes: 1 addition & 1 deletion internal/env/constants.go
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ const (
// interactive context selection when fzf is installed.
EnvFZFIgnore = "KUBECTX_IGNORE_FZF"

// EnvForceColor describes the environment variable to disable color usage
// EnvNoColor describes the environment variable to disable color usage
// when printing current context in a list.
EnvNoColor = `NO_COLOR`

Expand Down

0 comments on commit 0bcd0d5

Please sign in to comment.