-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Generics to go-linq #112
Open
lonegunmanb
wants to merge
56
commits into
ahmetb:master
Choose a base branch
from
lonegunmanb:generics
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix failed test in example_test file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey guys, I like go-linq very much and I'd like to add generics support for this lib long ago, this weekend I've tried.
The trickiest part is how to create parameterized method since golang cannot do that, for example we cannot declare the following method:
My way is declare some
Expander
type to do that. For this GroupJoin example:We can declare an
Expander
object to capture the extended type parameters we need, then cast the type immediately, then we decalre these type extended method on theseExpander
type. The only potential risk point that have no protection from the compiler is this type casting, but they're so close so I think the risk is limited.This pr is composed to learn go's generics and thanks to @ahmetb I had a lot of fun.