Issue-156: added IReadOnlyList and tests

agoda-com · Mar 3, 2021 · 91c6dd2 · 91c6dd2
1 parent caece74
commit 91c6dd2
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/src/Agoda.Analyzers.Test/AgodaCustom/AG0018UnitTests.cs b/src/Agoda.Analyzers.Test/AgodaCustom/AG0018UnitTests.cs
@@ -80,6 +80,8 @@ public class TestClass
         [TestCase("IReadOnlyDictionary<string, int>")]
         [TestCase("KeyedCollection<string, string>")]
         [TestCase("IEnumerable<string>")]
+        [TestCase("IReadOnlyCollection<string>")]
+        [TestCase("IReadOnlyList<string>")]
         public async Task AG0018_WithPermittedCollection_ShouldNotShowWarning(string type)
         {
             var code = $@"

diff --git a/src/Agoda.Analyzers/AgodaCustom/AG0018PermitOnlyCertainPubliclyExposedEnumerables.cs b/src/Agoda.Analyzers/AgodaCustom/AG0018PermitOnlyCertainPubliclyExposedEnumerables.cs
@@ -24,7 +24,8 @@ public class AG0018PermitOnlyCertainPubliclyExposedEnumerables : DiagnosticAnaly
             "System.Collections.Generic.IReadOnlyDictionary<TKey, TValue>",
             "System.Collections.Generic.KeyedCollection<TKey, TValue>",
             "System.Collections.Generic.IEnumerable<T>",
-            "System.Collections.Generic.IReadOnlyCollection<T>"
+            "System.Collections.Generic.IReadOnlyCollection<T>",
+            "System.Collections.Generic.IReadOnlyList<T>"
         };
 
         private static readonly LocalizableString Title = new LocalizableResourceString(