Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR cleans up a lot of the "local only" related logic from Android. The ABS Android app removed support for media which was not downloaded directly through the app (i.e. scanning local media from the file system) in app version
0.9.67-beta
, released November 2023. "Local only" media is defined as media which is not linked to an ABS server.The front-end is updated to not include local only checks or displays, and the back-end cleans the database of local only entries when initialized and checking for missing files to allow "local only" checks and logic to be removed.
Local progress for media downloaded from the server is still tracked when connected to a different server, as a different user, or when not connected to any server.
Detailed description
Notable commit summary:
isLocalOnly
from playback sessions and media progressFolderScanner
in preparation for commit 7AudioProbeResult
. This class is only used when scanning local only files, so the class was removed as well as all references. The references were not actually used anywhere else, but the data did exist inAudioTrack
, referenced inFolderScanner
.Testing
This was tested on a Pixel 6a using Android 15.
I have never had local only media and I am not sure how to add this sort of test data into the database within the app easily, so I am not 100% sure that the deletion is in the correct place. I am currently deleting the local only items during database initialization, which I believe would happen before anything else tries to load data. Because this functionality was removed over a year ago I don't expect the changes to the database to affect many people either.