fix(action-menu): dispatch scroll event #4715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rajdeepc
added
bug
Pull Request Test Coverage Report for Build 10695985787Details
💛 - Coveralls |
Lighthouse scores
What is this?Lighthouse scores comparing the documentation site built from the PR ("Branch") to that of the production documentation site ("Latest") and the build currently on Transfer Size
Request Count
|
Tachometer resultsChromeaction-menu permalinktest-basic
test-directive permalink
test-lazy permalink
test-open-close-directive permalink
test-open-close permalink
breadcrumbs permalinkbasic-test
picker permalinkbasic-test
split-button permalinkbasic-test
Firefoxaction-menu permalinktest-basic
test-directive permalink
test-lazy permalink
test-open-close-directive permalink
test-open-close permalink
breadcrumbs permalinkbasic-test
picker permalinkbasic-test
split-button permalinkbasic-test
|
rubencarvalho
approved these changes
Sep 3, 2024
nikkimk
pushed a commit
that referenced
this pull request
Sep 13, 2024
* fix(action-menu): dispatch scroll event * fix(action-menu): added open attribute for vrt * fix(action-menu): updated golden image cache * fix(action-menu): updated golden image cache * fix(action-menu): added unit tests * fix(action-menu): updated golden image cache * fix(action-menu): updated golden image cache * fix(action-menu): updated golden image cache --------- Co-authored-by: Rajdeep Chandra <[email protected]> Co-authored-by: Rajdeep Chandra <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@scrollevent is attached to thesp-menuin the Picker's render tree.Related issue(s)
Motivation and context
Switched one of our components from
sp-menutosp-action-menuin order to leverage the mobile UI built in withsp-action-menu.However, when we made the switch, we noticed that
@scrollstopped working as expected,How has this been tested?
Test case 1
mousewheelorupanddownkeys.Did it pass in Desktop?
Did it pass in Mobile?
Did it pass in iPad?
Screenshots (if appropriate)
Types of changes
Checklist
Best practices
This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against
main.