keep all English translations regardless of translated % #4232

matt-fidd · 2025-01-24T00:13:50Z

English localisations (en-GB for example) only need a few strings changing, the rest we can allow to fall back as they're common between the US original and GB localisation.

This prevents every string having to be copied over to any en translations and allowing only the differences to be added.

netlify · 2025-01-24T00:14:14Z

✅ Deploy Preview for actualbudget ready!

Name	Link
🔨 Latest commit	`0294678`
🔍 Latest deploy log	https://app.netlify.com/sites/actualbudget/deploys/6792e409dffcc10008e28ce3
😎 Deploy Preview	https://deploy-preview-4232.demo.actualbudget.org
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions · 2025-01-24T00:15:18Z

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
15	6.68 MB	0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
static/js/workbox-window.prod.es5.js	5.69 kB	0%
static/js/resize-observer.js	18.37 kB	0%
static/js/nl.js	58.58 kB	0%
static/js/indexeddb-main-thread-worker-e59fee74.js	13.5 kB	0%
static/js/en.js	99.31 kB	0%
static/js/AppliedFilters.js	10.52 kB	0%
static/js/en-GB.js	92.98 kB	0%
static/js/useAccountPreviewTransactions.js	1.69 kB	0%
static/js/pt-BR.js	103.38 kB	0%
static/js/BackgroundImage.js	122.29 kB	0%
static/js/uk.js	111.19 kB	0%
static/js/narrow.js	84.94 kB	0%
static/js/wide.js	102.8 kB	0%
static/js/ReportRouter.js	1.59 MB	0%
static/js/index.js	4.28 MB	0%

github-actions · 2025-01-24T00:15:19Z

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
1	1.33 MB	0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
kcab.worker.js	1.33 MB	0%

coderabbitai · 2025-01-24T00:16:57Z

Walkthrough

The pull request enhances the processTranslations function in the remove-untranslated-languages script located in the packages/desktop-client/bin/ directory. The changes include a revised logging message for the number of keys in en.json, which now reads en has ${enKeysCount} keys. The logic for processing locale files has been restructured to filter out en.json, focusing solely on JSON files and storing locales in an array. Two new arrays, usableLanguages and usableLocales, are introduced, initialized with the English language and locale. The percentage of keys in each locale compared to en.json is calculated, and locales exceeding 50% are added to these arrays. The deletion logic has been updated to remove locales not in usableLanguages, with log messages reflecting locale names instead of file names.

Possibly related PRs

Exclude untranslated languages from builds #4148: The changes in this PR directly involve the remove-untranslated-languages script, which is the same file modified in the main PR, indicating a strong connection in functionality related to managing untranslated languages.

Suggested Labels

:sparkles: Merged

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3d8b8ac and 0294678.

📒 Files selected for processing (1)

packages/desktop-client/bin/remove-untranslated-languages (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

packages/desktop-client/bin/remove-untranslated-languages

⏰ Context from checks skipped due to timeout of 90000ms (5)

GitHub Check: build (macos-latest)
GitHub Check: build (windows-latest)
GitHub Check: Wait for Netlify build to finish
GitHub Check: Analyze
GitHub Check: build (ubuntu-latest)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

packages/desktop-client/bin/remove-untranslated-languages (1)
26-29: Consider case-insensitive matching for English variants.

If you ever need to handle files named with uppercase or mixed-case prefixes (e.g., "EN-GB.json", "En-CA.json"), modifying the condition to a case-insensitive check would ensure that all English variants are uniformly retained.

Example update:
- if (file.startsWith('en-')) {
+ if (file.toLowerCase().startsWith('en-')) {

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f09f4af and 5c01adf.

⛔ Files ignored due to path filters (1)

upcoming-release-notes/4232.md is excluded by !**/*.md

📒 Files selected for processing (1)

packages/desktop-client/bin/remove-untranslated-languages (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (5)

GitHub Check: Visual regression
GitHub Check: Functional
GitHub Check: build (macos-latest)
GitHub Check: build (windows-latest)
GitHub Check: build (ubuntu-latest)

jfdoming

Good idea! Maybe we should do the same for all regional languages that have a translated parent? Would probably have to do two passes but I think that's fine

matt-fidd · 2025-01-24T01:02:56Z

Hmm.. does i18n sort falling back within languages for us or will that need a bigger change?
Will untranslated strings in a Portugese region fall back to a main Portugese pt.json or English?

matt-fidd added 2 commits January 24, 2025 00:12

keep all English translations regardless of translated %

66ea888

note

5c01adf

matt-fidd requested a review from jfdoming January 24, 2025 00:13

actual-github-bot bot changed the title ~~keep all English translations regardless of translated %~~ [WIP] keep all English translations regardless of translated % Jan 24, 2025

actual-github-bot bot added the 🚧 WIP label Jan 24, 2025

matt-fidd changed the title ~~[WIP] keep all English translations regardless of translated %~~ keep all English translations regardless of translated % Jan 24, 2025

actual-github-bot bot added 🔍 Ready for review and removed 🚧 WIP labels Jan 24, 2025

coderabbitai bot reviewed Jan 24, 2025

View reviewed changes

jfdoming reviewed Jan 24, 2025

View reviewed changes

matt-fidd added 2 commits January 24, 2025 00:41

allow all locales to fall back to another of their language

3d8b8ac

misunderstood how the fallback logic works

0294678

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

keep all English translations regardless of translated % #4232

keep all English translations regardless of translated % #4232

matt-fidd commented Jan 24, 2025 •

edited

Loading

netlify bot commented Jan 24, 2025 •

edited

Loading

github-actions bot commented Jan 24, 2025 •

edited

Loading

github-actions bot commented Jan 24, 2025 •

edited

Loading

coderabbitai bot commented Jan 24, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

coderabbitai bot left a comment

jfdoming left a comment

matt-fidd commented Jan 24, 2025

keep all English translations regardless of translated % #4232

Are you sure you want to change the base?

keep all English translations regardless of translated % #4232

Conversation

matt-fidd commented Jan 24, 2025 • edited Loading

netlify bot commented Jan 24, 2025 • edited Loading

✅ Deploy Preview for actualbudget ready!

github-actions bot commented Jan 24, 2025 • edited Loading

Bundle Stats — desktop-client

github-actions bot commented Jan 24, 2025 • edited Loading

Bundle Stats — loot-core

coderabbitai bot commented Jan 24, 2025 • edited Loading

Walkthrough

Possibly related PRs

Suggested Labels

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

coderabbitai bot left a comment

Choose a reason for hiding this comment

jfdoming left a comment

Choose a reason for hiding this comment

matt-fidd commented Jan 24, 2025

matt-fidd commented Jan 24, 2025 •

edited

Loading

netlify bot commented Jan 24, 2025 •

edited

Loading

github-actions bot commented Jan 24, 2025 •

edited

Loading

github-actions bot commented Jan 24, 2025 •

edited

Loading

coderabbitai bot commented Jan 24, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)