Put parameters back into play

achaikou · Jan 25, 2024 · 26b3fe2 · 26b3fe2
1 parent ad4ba27
commit 26b3fe2
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/.github/workflows/windows.yml b/.github/workflows/windows.yml
@@ -22,10 +22,10 @@ jobs:
           cmake_generator: '-G "Visual Studio 16 2019" -A Win32'
         - platform: x64
           cmake_generator: '-G "Visual Studio 16 2019" -A x64'
-        - fmt-header-only: 'ON'
+        - fmt-header-only: ON
         - platform: x64
           config: Release
-          fmt-header-only: 'OFF'
+          fmt-header-only: OFF
 
     steps:
     - name: explicitly disable autocrlf
@@ -66,7 +66,8 @@ jobs:
         cd build
         cmake                                   \
           -DCMAKE_POSITION_INDEPENDENT_CODE=ON  \
-          -DLFP_FMT_HEADER_ONLY=ON              \
+          -DLFP_FMT_HEADER_ONLY=${{ matrix.fmt-header-only }} \
+          -DCMAKE_BUILD_TYPE=${{ matrix.config }} \
           ${{ matrix.cmake_generator  }}             \
           ..
         cmake --build . --config ${{ matrix.config }} --target install