Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix race condition between local expiration and rocksdb restore #47

Merged
merged 2 commits into from
May 10, 2018

Conversation

wangjian-pg
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented May 9, 2018

Codecov Report

Merging #47 into master will increase coverage by <.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #47      +/-   ##
==========================================
+ Coverage   44.53%   44.54%   +<.01%     
==========================================
  Files         149      149              
  Lines       21788    21789       +1     
==========================================
+ Hits         9703     9705       +2     
+ Misses      10483    10482       -1     
  Partials     1602     1602
Impacted Files Coverage Δ
rockredis/rockredis.go 34% <50%> (-0.05%) ⬇️
pkg/fileutil/fileutil.go 69.56% <0%> (ø) ⬆️
node/ttl.go 35.15% <0%> (ø) ⬆️
transport/rafthttp/stream.go 80.13% <0%> (+0.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 280f0c3...7b67f21. Read the comment docs.

Copy link
Owner

@absolute8511 absolute8511 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@absolute8511 absolute8511 merged commit f140777 into master May 10, 2018
absolute8511 added a commit that referenced this pull request Jul 8, 2022
update gogo protobuf to v1.2.1 and fix checkpoint purge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants