Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust return type of command 'georadius' #33

Merged
merged 1 commit into from
Dec 27, 2017
Merged

Conversation

wangjian-pg
Copy link
Collaborator

Change the hash value type from bulk to integer as redis do.

@codecov
Copy link

codecov bot commented Dec 26, 2017

Codecov Report

Merging #33 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #33      +/-   ##
==========================================
- Coverage   47.88%   47.87%   -0.01%     
==========================================
  Files         103      103              
  Lines       17642    17641       -1     
==========================================
- Hits         8447     8446       -1     
+ Misses       7816     7815       -1     
- Partials     1379     1380       +1
Impacted Files Coverage Δ
node/geo.go 63.11% <100%> (-0.14%) ⬇️
transport/rafthttp/stream.go 80.13% <0%> (-0.66%) ⬇️
transport/rafthttp/peer.go 77.09% <0%> (+1.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42aba60...eb42868. Read the comment docs.

Copy link
Owner

@absolute8511 absolute8511 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@absolute8511 absolute8511 merged commit 511e702 into master Dec 27, 2017
@wangjian-pg wangjian-pg deleted the hotfix/geohash branch December 27, 2017 02:40
absolute8511 added a commit that referenced this pull request Jul 8, 2022
avoid retry old snapshot while sync cluster
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants