Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support geohash API(#14) #28

Merged
merged 1 commit into from
Nov 21, 2017
Merged

Support geohash API(#14) #28

merged 1 commit into from
Nov 21, 2017

Conversation

wangjian-pg
Copy link
Collaborator

Support the redis geohash API(#14). The implementation is derived from the C code of Redis.

@codecov
Copy link

codecov bot commented Oct 7, 2017

Codecov Report

Merging #28 into master will increase coverage by 0.14%.
The diff coverage is 49.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #28      +/-   ##
==========================================
+ Coverage   51.07%   51.21%   +0.14%     
==========================================
  Files          95       99       +4     
  Lines       15367    16346     +979     
==========================================
+ Hits         7848     8371     +523     
- Misses       6229     6631     +402     
- Partials     1290     1344      +54
Impacted Files Coverage Δ
common/geohash/type.go 0% <0%> (ø)
node/node_cmd_reg.go 100% <100%> (ø) ⬆️
common/geohash/util.go 23.03% <23.03%> (ø)
node/geo.go 63.25% <63.25%> (ø)
common/geohash/geohash.go 83.63% <83.63%> (ø)
transport/rafthttp/peer.go 75.57% <0%> (-1.53%) ⬇️
transport/rafthttp/stream.go 80.13% <0%> (-1.31%) ⬇️
node/raft.go 40.41% <0%> (-0.13%) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82c3ace...7224d88. Read the comment docs.

Copy link
Owner

@absolute8511 absolute8511 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@absolute8511
Copy link
Owner

Will be merged after the next release.

@absolute8511 absolute8511 merged commit 2229bbf into master Nov 21, 2017
@wangjian-pg wangjian-pg deleted the geohash branch January 15, 2018 11:33
@wangjian-pg wangjian-pg restored the geohash branch January 15, 2018 11:33
absolute8511 added a commit that referenced this pull request Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants