Fixed spelling mistakes

[ghost]

No description provided.

[absoIute]

you disappear for weeks and come back for THIS??

[ghost]

Grammar is important, Ben.

[absoIute]

the British spelling is the right 😡

[qimiko]

i think we merge this in solidarity

[camila314]

i agree, this will be too iconic to just close

[qimiko]

i propose a preprocessor variable to maintain backwards compatibility as well, something like this:

#ifdef BRITISH_MH7
#error cos8o says British people aren't allowed.
#else
	class MH_DLL ColorPicker
	{
		typedef void (MH_CALL *Callback)(ColorPicker *, Color);
	public:
		ColorPicker() = delete;
		ColorPicker(const ColorPicker &) = delete;
		ColorPicker &operator=(const ColorPicker &) = delete;
		~ColorPicker() = delete;

		static ColorPicker *Create(Color color);

		void setCallback(Callback callback);

		void set(Color color, bool trigger_callback = true);
		Color get() const;
	};
#endif

[Wyliemaster]

ew this pull request is littered with spelling mistakes

[FigmentBoy]

any update on this? seems to me like this is ready to merge.

[absoIute]

sadly v7 has the colour in its exports already so you might have to #define your incorrect spellings instead

[FigmentBoy]

Sometimes breaking changes are needed to fix important issues.

[absoIute]

when breaking changes can be avoided and important issues can be resolved sometimes, if non-breaking changes are made to the pull it may be merged!

[FigmentBoy]

i propose a preprocessor variable to maintain backwards compatibility as well, something like this:

#ifdef BRITISH_MH7
#error cos8o says British people aren't allowed.
#else
	class MH_DLL ColorPicker
	{
		typedef void (MH_CALL *Callback)(ColorPicker *, Color);
	public:
		ColorPicker() = delete;
		ColorPicker(const ColorPicker &) = delete;
		ColorPicker &operator=(const ColorPicker &) = delete;
		~ColorPicker() = delete;

		static ColorPicker *Create(Color color);

		void setCallback(Callback callback);

		void set(Color color, bool trigger_callback = true);
		Color get() const;
	};
#endif

Thats where this proposed change comes in handy

[absoIute]

not backwards compatible with older versions!

strike 1

[qimiko]

I personally think we should follow the wisdom of semantic versioning and create Mega Hack v8. This will allow us to make the necessary breaking changes, while clearly communicating to extension developers that they are immensely British.

[absoIute]

also comes with the bonus of being easily marketable as a new version, so people will adopt the update quicker than usual, good idea

[ghost]

merge this, its better and minified