-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow newer dependencies, test GHC 9.10.1 #64
Conversation
@@ -9,14 +9,14 @@ jobs: | |||
runs-on: ${{ matrix.os }} | |||
strategy: | |||
matrix: | |||
ghc: ['8.4.4', '8.6.5', '8.8.3', '8.10.2', '9.0.1', '9.2.1', '9.4.2', '9.6.3', '9.8.1'] | |||
ghc: ['8.4.4', '8.6.5', '8.8.4', '8.10.7', '9.0.1', '9.2.8', '9.4.8', '9.6.6', '9.8.2', '9.10.1'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Semi-related:
I haven't been keeping up with the ecosystem, but I think it might be fine to drop everything before the 9.x series.
ghc: ['8.4.4', '8.6.5', '8.8.4', '8.10.7', '9.0.1', '9.2.8', '9.4.8', '9.6.6', '9.8.2', '9.10.1'] | |
ghc: ['9.0.1', '9.2.8', '9.4.8', '9.6.6', '9.8.2', '9.10.1'] |
9.0.1 was released in Feb 2021, so 3 years doesn't feel like a bad cutoff for an ecosystem that moves pretty fast.
But I would appreciate thoughts from someone more involved.
What are your thoughts, @ysangkok?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's nice to keep support if it doesn't cost anything and CI can still test it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair. I'm mostly thinking of [hypothetical future] where supporting a really old version requires #ifdef
and friends. Although since it's not a problem right now, that's moot for now.
- uses: actions/checkout@v4 | ||
- name: Setup Haskell | ||
uses: haskell/actions/setup@v1 | ||
uses: haskell-actions/setup@v2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for fixing
Thanks! published https://hackage.haskell.org/package/pinch-0.5.2.0 |
Tested using
Fixes #61
This also addresses Stackage issues like