Skip to content

Commit

Permalink
bumped up version # in preparation for new release.
Browse files Browse the repository at this point in the history
Signed-off-by: abbr <[email protected]>
  • Loading branch information
abbr committed Jul 18, 2014
1 parent 7546c68 commit e002622
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 2 deletions.
1 change: 0 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,6 @@ Platforms older than Windows 2000 are unlikely to work. Other platforms may work
## Caveats
* NodeSSPI is still early in development. Microsoft provides a number of SSPI [packages](http://msdn.microsoft.com/en-us/library/windows/desktop/aa380502(v=vs.85).aspx). So far only NTLM and Negotiate have been tested working. Kerberos is not working. Contribution is encouraged.
* No tests have been performed on servers with unicode system locale.
* All WinAPI calls including SSPI authentication and group retrievals are performed synchronously, during which Node.js thread is blocked while the server is communicating with the domain controler. Therefore there is potential performance impact. Fixing is underway.

## Installation
Prerequisites: Except on a few [ platforms + V8 version combinations](https://github.com/abbr/NodeSSPI-bin) where binary distribution is included, NodeSSPI uses node-gyp to compile C++ source code so you may need the compilers listed in [node-gyp](https://github.com/TooTallNate/node-gyp). You may also need to [update npm's bundled node gyp](https://github.com/TooTallNate/node-gyp/wiki/Updating-npm's-bundled-node-gyp).
Expand Down
4 changes: 4 additions & 0 deletions index.js
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,10 @@ function main(opts) {
}

main.prototype.authenticate = function (req, res, cb) {
if (typeof cb !== 'function') {
res.statusCode = 500;
res.end('missing callback');
}
if (this.opts.perRequestAuth) {
delete req.connection.user;
}
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "node-sspi",
"version": "0.1.0",
"version": "0.1.1",
"description": "Windows SSPI server-side authentication for Node",
"main": "index.js",
"author": "Fred Wen<[email protected]>",
Expand Down
1 change: 1 addition & 0 deletions src/NodeSSPI.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -498,6 +498,7 @@ void AsyncAfterBasicAuth(uv_work_t* uvReq, int status) {
catch (NodeSSPIException *ex){
pBaton->err = ex;
}
// SCR doesn't span across requests for basic auth
delete pBaton->pSCR;
WrapUpAsyncAfterAuth(pBaton);
}
Expand Down

0 comments on commit e002622

Please sign in to comment.