Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop python 3.8, use ruff #633

Merged
merged 22 commits into from
Jan 12, 2025
Merged

Drop python 3.8, use ruff #633

merged 22 commits into from
Jan 12, 2025

Conversation

mdbenito
Copy link
Collaborator

@mdbenito mdbenito commented Jan 12, 2025

Description

This PR closes #630, closes #548, addresses some of #617, closes #634

Ruff is not without quirks and this PR has made me think hard again about the time-tested principle "if it works, don't fix it" :/

Changes

  • Pins the base runner image to Ubuntu 22.04
  • Drops 3.8 and sets the base env for tox to 3.9 (this is a PITA for some debian-based distros that don't include distutils for python 3.9 so one must use conda for the environment)
  • Drops pylint and black in favour of ruff, updating pre-commit config too
  • Fixes a bunch of warnings and deactivates several in ruff's config for convenience (but we should pay attention to line lenghts)
  • Updates some package versions, like joblib which released generator_unordered behaviour in 1.4.0
  • Pins zarr to be < 3 to avoid some breaking changes
  • Makes necessary changes to run with numpy 2.0. However, dask seems not to work with this because it internally references e.g. np.float_ which raises AttributeErrors under numpy 2.0

Checklist

  • Wrote Unit tests (if necessary)
  • Updated Documentation (if necessary)
  • Updated Changelog
  • If notebooks were added/changed, added boilerplate cells are tagged with "tags": ["hide"] or "tags": ["hide-input"]

@mdbenito mdbenito mentioned this pull request Jan 12, 2025
mdbenito added a commit that referenced this pull request Jan 12, 2025
@mdbenito mdbenito merged commit 454b109 into develop Jan 12, 2025
@mdbenito mdbenito deleted the feature/drop-python-38 branch January 12, 2025 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant