Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor KNN Shapley #610

Merged
merged 14 commits into from
Jul 28, 2024
Merged

Refactor KNN Shapley #610

merged 14 commits into from
Jul 28, 2024

Conversation

janosg
Copy link
Collaborator

@janosg janosg commented Jul 7, 2024 •
edited
Loading

Description

This PR refactors the KNN shapley valuations to be more aligned with the new Valuation classes.

Changes

  • Completely refactor KNN Shapley
  • Add parallelization
  • Add more tests

closes #613

Checklist

  • Wrote Unit tests (if necessary)
  • Updated Documentation (if necessary)
  • Updated Changelog

@janosg janosg merged commit 6353dc4 into feature/refactor-value Jul 28, 2024
@mdbenito mdbenito deleted the feature/refactor-knn-shapley branch November 13, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schroedk schroedk schroedk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@janosg @schroedk