Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge Hanh's work #21

Merged
merged 4 commits into from
May 24, 2020
Merged

Merge Hanh's work #21

merged 4 commits into from
May 24, 2020
+181 −134

Conversation

nvti
Copy link
Member

@nvti nvti commented May 24, 2020 •
edited
Loading

What does this MR do?

Merge Hanh's work

Related issues

Close #19

Author's checklist

  • Link related issues. If no related issue, create issue first.
  • Target to right branch
  • Set milestone
  • Assign to a reviewer
  • Apply label.

Review checklist

@nvti nvti requested a review from honghanhh May 24, 2020 06:14
@nvti nvti self-assigned this May 24, 2020
@nvti nvti added the enhancement New feature or request label May 24, 2020
@nvti nvti added this to the Complete week 1 milestone May 24, 2020
@nvti nvti changed the title update Merge Hanh's work May 24, 2020
@nvti nvti changed the title Merge Hanh's work [WIP]: Merge Hanh's work May 24, 2020
@nvti nvti changed the title [WIP]: Merge Hanh's work Merge Hanh's work May 24, 2020
@nvti nvti merged commit f4a29d4 into master May 24, 2020
@nvti nvti deleted the merge_assignment1 branch May 24, 2020 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@honghanhh honghanhh honghanhh approved these changes

Assignees

@nvti nvti

Labels
enhancement New feature or request
Projects
None yet
Milestone
Complete week 1
Development

Successfully merging this pull request may close these issues.

[FEATURE] Finish assignment1
2 participants
@nvti @honghanhh