Futurize for Python 2 & 3 support #38
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the `futurize` command: ``` futurize -w datareader.py ``` this file runs (untested) under Python 3: ``` python datareader.py usage: <movie> ``` This requires having the `future` module installed at runtime. see: - https://python-future.org/compatible_idioms.html - https://docs.python.org/3/howto/pyporting.html
|
This looks both wrong and unneeded. Closing and if @mengzhang1003 and I run into any concrete blockers while using python3 I'll raise them. |
|
Okay, I do appreciate the extra eyes. I think the Python 3 support is solid though as I use this all the time with Python 3.6, and most of the project is routinely tested in Python 3 by both travis-ci and appveyor. If you do find anything that doesn't work in Python 3 please let me know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the
futurizecommand:this file runs (untested) under Python 3:
This requires having the
futuremodule installed at runtime. So far this PR only appliesfuturizetodatareader.pyfor working with @mengzhang1003 during SpaceJam. Running it across more of the codebase could be done either in this PR or as a follow. More important is the general choice of strategy for supporting Python 3 at runtime.see: