Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancements to Visualizer #33

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

evanheller
Copy link
Contributor

Migrated some features I liked from matlab-storm to Visualizer: a GUI to play with DAOSTORM parameters and preview the result, import/export DAOSTORM xmlfiles, and buttons to launch single or batch analysis. Any interest?

@HazenBabcock
Copy link
Member

I always love your work. One question however, I thought that HDF5 files had a ".hdf5" extension and not ".h5"? Or at least that is what I always use..

@evanheller
Copy link
Contributor Author

evanheller commented Jun 23, 2018 via email

@HazenBabcock
Copy link
Member

I've been using ".hdf5" in the documentation and my own work so that would be my preference.

Now that I've looked at what you propose I'd prefer that it was separate from visualizer, in it's own folder storm_analysis\analyzer and called analyzer. If you are motivated you could factor out the common bits, if not then feel free to just move it and revert visualizer and we can sort out the rest later.

Suggested improvements:

  1. You need to make better use of layouts so that GUI elements stretch / contract properly when the window is resized. Otherwise it is only going to look good on your computer at your preferred size.
  2. A splitter between the movie view and the parameters is a good idea so that they are not automatically split 50/50.
  3. I'd use a list view or tree view for the parameters. This will automatically handle scrolling etc. You could look at HAL2's parameter editor for one possible example of how to do this.
  4. The parameters have documentation strings that could be used as tooltips.
  5. A more programmatic approach to creating the parameter editor UI would make it much easier to update this in the future so that it worked with any of the analysis approaches, or at least the single camera approaches.
  6. You've done something to the GraphicsView so that when you load a movie it is not automatically centered? And really small?
  7. I prefer a vertical image contrast bar.

@superchromix
Copy link

Hi Hazen,

FYI, as far as I'm aware, ".h5" is the standard file extension for HDF5, and is also what I use in my work.

Mark

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants