Initial validation test #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contracted capacity test
macano
force-pushed
the
137-test-validations
branch
from
2ca905e to
9f8f651
Compare
Erikvv
requested changes
Oct 17, 2024
| @@ -17,7 +17,7 @@ data class GridConnection( | |||
| // Is always set when object comes from the database. | |||
| val sequence: Int? = null, | |||
|
|
|||
| val electricity: Electricity = Electricity(), | |||
| val electricity: Electricity? = Electricity(), | |||
There was a problem hiding this comment.
Better keep it non-nullable because in AnyLogic/Java there is no null-safe navigation operator "?." so the modellers will have to write extra null checks.
| val contractedConnectionCapacity = gridConnection.electricity.getContractedConnectionCapacityKw() | ||
| val physicalConnectionCapacity = gridConnection.electricity.getPhysicalConnectionCapacityKw() | ||
| val contractedConnectionCapacity = gridConnection.electricity?.getContractedConnectionCapacityKw() | ||
| val physicalConnectionCapacity = gridConnection.electricity?.grootverbruik?.physicalCapacityKw |
There was a problem hiding this comment.
With this code, in the case of kleinverbruik, it will say Status.MISSING_DATA. But this is not true.
I think the previous version was good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #137
Contracted capacity test