Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: semaphore circuit integration #17

Merged

Conversation

khayss
Copy link
Contributor

@khayss khayss commented Dec 1, 2024

Semaphore Circuit Integration

📝 Summary

This PR provides a research docs for semaphore circuit implementation.

🔗 Related Issues

🔄 Changes Made

Added research docs for semaphore circuit implementation in /research. This contains details about the constraint and challenges implementing the semaphore circuit for stellar blockchain.

🧪 Testing

Not applicable

🖼️ Screenshots & Resources

Not applicable

✅ Self-Check for Contribution Requirements

Mark with an x all the checkboxes that apply (like [x]).

  • Forked the repository and created a new branch with a meaningful name.
  • Ensured that the content is clear and free of grammatical errors.
  • Maintained consistency in tone and formatting throughout the document.
  • Verified that all links work correctly and checked for typos before submitting the changes.
  • Used the conventional commit format for commit messages.
  • Thoroughly tested changes, including unit tests if applicable.

💬 Comments

No comments.

@khayss
Copy link
Contributor Author

khayss commented Dec 1, 2024

@evgongora kindly review. I'll be waiting for your feedback :)

@evgongora
Copy link
Collaborator

@khayss LGTM! You could add a little bit of what's been said here ZencypherSolutions/semaphore-stellar-contracts#2 (comment)

@khayss
Copy link
Contributor Author

khayss commented Dec 1, 2024

Great. I'll add that.

@khayss
Copy link
Contributor Author

khayss commented Dec 2, 2024

Hey @evgongora. I have added more information based on the resource you shared. Thank you. Kindly, review.

Copy link
Contributor

@bitfalt bitfalt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Just a small change, and we'll merge your PR

@khayss
Copy link
Contributor Author

khayss commented Dec 2, 2024

Will make the changes now

@khayss
Copy link
Contributor Author

khayss commented Dec 2, 2024

Hey @bitfalt, I have made the requested changes.

@bitfalt bitfalt marked this pull request as ready for review December 2, 2024 21:08
@bitfalt
Copy link
Contributor

bitfalt commented Dec 2, 2024

lgtm! Nice work overall :D

@bitfalt bitfalt merged commit 689bfba into ZencypherSolutions:main Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Research Docs] Issue 6: Integrate and leverage the Semaphore circuit into the project structure
3 participants