refactor: switch to template strings for errors.

lib/bip70/paymentrequest.js

@@ -161,10 +161,10 @@ PaymentRequest.prototype.getAlgorithm = function getAlgorithm() {
     throw new Error('Could not parse PKI algorithm.');
 
   if (parts[0] !== 'x509')
-    throw new Error('Unknown PKI type: ' + parts[0]);
+    throw new Error(`Unknown PKI type: ${parts[0]}.`);
 
   if (parts[1] !== 'sha1' && parts[1] !== 'sha256')
-    throw new Error('Unknown hash algorithm: ' + parts[1]);
+    throw new Error(`Unknown hash algorithm: ${parts[1]}.`);
 
   return new Algorithm(parts[0], parts[1]);
 };

lib/bip70/x509.js

@@ -189,7 +189,7 @@ x509.getKeyAlgorithm = function getKeyAlgorithm(cert) {
   let alg = x509.oid[oid];
 
   if (!alg)
-    throw new Error('Unknown key algorithm: ' + oid);
+    throw new Error(`Unknown key algorithm: ${oid}.`);
 
   return alg;
 };
@@ -205,7 +205,7 @@ x509.getSigAlgorithm = function getSigAlgorithm(cert) {
   let alg = x509.oid[oid];
 
   if (!alg || !alg.hash)
-    throw new Error('Unknown signature algorithm: ' + oid);
+    throw new Error(`Unknown signature algorithm: ${oid}.`);
 
   return alg;
 };
@@ -228,7 +228,7 @@ x509.getCurve = function getCurve(params) {
   curve = x509.curves[oid];
 
   if (!curve)
-    throw new Error('Unknown ECDSA curve: ' + oid);
+    throw new Error(`Unknown ECDSA curve: ${oid}.`);
 
   return curve;
 };
@@ -457,7 +457,7 @@ x509.verifyChain = function verifyChain(certs) {
     let sig = child.sig;
 
     if (!pk.verify(alg.hash, msg, sig, key))
-      throw new Error(alg.key + ' verification failed for chain.');
+      throw new Error(`${alg.key} verification failed for chain.`);
   }
 
   // Make sure we trust one

lib/blockchain/chaindb.js

@@ -712,7 +712,7 @@ ChainDB.prototype.prune = async function prune(tip) {
     let hash = await this.getHash(i);
 
     if (!hash)
-      throw new Error('Cannot find hash for ' + i);
+      throw new Error(`Cannot find hash for ${i}.`);
 
     batch.del(layout.b(hash));
     batch.del(layout.u(hash));

lib/btc/amount.js

@@ -120,7 +120,7 @@ Amount.prototype.to = function to(unit, num) {
     case 'btc':
       return this.toBTC(num);
   }
-  throw new Error('Unknown unit "' + unit + '".');
+  throw new Error(`Unknown unit "${unit}".`);
 };
 
 /**
@@ -218,7 +218,7 @@ Amount.prototype.from = function from(unit, value, num) {
     case 'btc':
       return this.fromBTC(value, num);
   }
-  throw new Error('Unknown unit "' + unit + '".');
+  throw new Error(`Unknown unit "${unit}".`);
 };
 
 /**

lib/crypto/pbkdf2-browser.js

@@ -98,6 +98,6 @@ function getHash(name) {
     case 'sha512':
       return 'SHA-512';
     default:
-      throw new Error('Algorithm not supported: ' + name);
+      throw new Error(`Algorithm not supported: ${name}.`);
   }
 }

lib/db/backends.js

@@ -18,11 +18,11 @@ exports.get = function get(name) {
       case 'memory':
         return require('./memdb');
       default:
-        throw new Error('Database backend "' + name + '" not found.');
+        throw new Error(`Database backend "${name}" not found.`);
     }
   } catch (e) {
     if (e.code === 'MODULE_NOT_FOUND')
-      throw new Error('Database backend "' + name + '" not found.');
+      throw new Error(`Database backend "${name}" not found.`);
     throw e;
   }
 };

lib/hd/wordlist-browser.js

@@ -25,6 +25,6 @@ exports.get = function get(name) {
     case 'spanish':
       return words.spanish;
     default:
-      throw new Error('Unknown language: ' + name);
+      throw new Error(`Unknown language: ${name}.`);
   }
 };

lib/hd/wordlist.js

@@ -23,6 +23,6 @@ exports.get = function get(name) {
     case 'spanish':
       return require('./words/spanish.js');
     default:
-      throw new Error('Unknown language: ' + name);
+      throw new Error(`Unknown language: ${name}.`);
   }
 };

lib/http/base.js

@@ -68,10 +68,9 @@ HTTPBase.prototype._init = function _init() {
   this.server.on('connection', (socket) => {
     socket.on('error', (err) => {
       if (err.message === 'Parse Error') {
-        let msg = 'http_parser.execute failure (';
-        msg += 'parsed=' + (err.bytesParsed || -1);
-        msg += ' code=' + err.code;
-        msg += ')';
+        let msg = 'http_parser.execute failure';
+        msg += ` (parsed=${err.bytesParsed || -1}`;
+        msg += ` code=${err.code})`;
         err = new Error(msg);
       }
 
@@ -134,7 +133,7 @@ HTTPBase.prototype.handleRequest = async function handleRequest(req, res) {
   routes = this.routes.getHandlers(req.method);
 
   if (!routes)
-    throw new Error('No routes found for method: ' + req.method);
+    throw new Error(`No routes found for method: ${req.method}.`);
 
   for (let route of routes) {
     let params = route.match(req.pathname);
@@ -151,7 +150,7 @@ HTTPBase.prototype.handleRequest = async function handleRequest(req, res) {
       return;
   }
 
-  throw new Error('No routes found for path: ' + req.pathname);
+  throw new Error(`No routes found for path: ${req.pathname}.`);
 };
 
 /**

lib/http/request.js

@@ -602,7 +602,7 @@ function getType(type) {
     case 'bin':
       return 'application/octet-stream';
     default:
-      throw new Error('Unknown type: ' + type);
+      throw new Error(`Unknown type: ${type}.`);
   }
 }
 

lib/http/rpc.js

@@ -1355,7 +1355,7 @@ RPC.prototype._createTemplate = async function _createTemplate(maxVersion, coinb
         if (!deploy.force) {
           if (!rules || rules.indexOf(name) === -1) {
             throw new RPCError(errs.INVALID_PARAMETER,
-              'Client must support ' + name + '.');
+              `Client must support ${name}.`);
           }
           name = '!' + name;
         }
@@ -2398,7 +2398,7 @@ RPC.prototype._addBlock = async function _addBlock(block) {
     if (err.type === 'VerifyError') {
       this.logger.warning('RPC block rejected: %s (%s).',
         block.rhash(), err.reason);
-      return 'rejected: ' + err.reason;
+      return `rejected: ${err.reason}`;
     }
     throw err;
   }

lib/http/rpcbase.js

@@ -253,7 +253,7 @@ RPCBase.prototype.execute = async function execute(json, help) {
         return await mount.execute(json, help);
     }
     throw new RPCError(RPCBase.errors.METHOD_NOT_FOUND,
-      'Method not found: ' + json.method + '.');
+      `Method not found: ${json.method}.`);
   }
 
   return await func.call(this, json.params, help);

lib/http/server.js

@@ -8,6 +8,7 @@
 'use strict';
 
 const assert = require('assert');
+const path = require('path');
 const HTTPBase = require('./base');
 const util = require('../utils/util');
 const base58 = require('../utils/base58');
@@ -774,8 +775,8 @@ HTTPOptions.prototype.fromOptions = function fromOptions(options) {
   if (options.prefix != null) {
     assert(typeof options.prefix === 'string');
     this.prefix = options.prefix;
-    this.keyFile = this.prefix + '/key.pem';
-    this.certFile = this.prefix + '/cert.pem';
+    this.keyFile = path.join(this.prefix, 'key.pem');
+    this.certFile = path.join(this.prefix, 'cert.pem');
   }
 
   if (options.host != null) {

lib/mempool/mempool.js

@@ -7,6 +7,7 @@
 'use strict';
 
 const assert = require('assert');
+const path = require('path');
 const AsyncObject = require('../utils/asyncobject');
 const common = require('../blockchain/common');
 const policy = require('../protocol/policy');
@@ -2057,7 +2058,7 @@ MempoolOptions.prototype.fromOptions = function fromOptions(options) {
   if (options.prefix != null) {
     assert(typeof options.prefix === 'string');
     this.prefix = options.prefix;
-    this.location = this.prefix + '/mempool';
+    this.location = path.join(this.prefix, 'mempool');
   }
 
   if (options.location != null) {

lib/net/bip150.js

@@ -417,7 +417,7 @@ BIP150.prototype._wait = function wait(timeout, resolve, reject) {
   this.job = co.job(resolve, reject);
 
   if (this.outbound && !this.peerIdentity) {
-    this.reject(new Error('No identity for ' + this.hostname + '.'));
+    this.reject(new Error(`No identity for ${this.hostname}.`));
     return;
   }
 
@@ -729,7 +729,7 @@ AuthDB.prototype.parseKnown = function parseKnown(text) {
     key = Buffer.from(key, 'hex');
 
     if (key.length !== 33)
-      throw new Error('Invalid key: ' + parts[1]);
+      throw new Error(`Invalid key: ${parts[1]}.`);
 
     if (host && host.length > 0)
       this.addKnown(host, key);
@@ -792,7 +792,7 @@ AuthDB.prototype.parseAuth = function parseAuth(text) {
     key = Buffer.from(line, 'hex');
 
     if (key.length !== 33)
-      throw new Error('Invalid key: ' + line);
+      throw new Error(`Invalid key: ${line}.`);
 
     this.addAuthorized(key);
   }

lib/net/common.js

@@ -134,7 +134,7 @@ exports.REQUIRED_SERVICES = 0
  * @default
  */
 
-exports.USER_AGENT = '/bcoin:' + pkg.version + '/';
+exports.USER_AGENT = `/bcoin:${pkg.version}/`;
 
 /**
  * Max message size (~4mb with segwit, formerly 2mb)

lib/net/peer.js

@@ -1419,10 +1419,10 @@ Peer.prototype.error = function error(err) {
     msg = err.code;
     err = new Error(msg);
     err.code = msg;
-    err.message = 'Socket Error: ' + msg;
+    err.message = `Socket Error: ${msg}`;
   }
 
-  err.message += ' (' + this.hostname() + ')';
+  err.message += ` (${this.hostname()})`;
 
   this.emit('error', err);
 };

lib/net/socks.js

@@ -735,7 +735,7 @@ function parseAddr(data, offset) {
       port = br.readU16BE();
       break;
     default:
-      throw new Error('Unknown SOCKS address type: ' + type + '.');
+      throw new Error(`Unknown SOCKS address type: ${type}.`);
   }
 
   return {

lib/net/upnp.js

@@ -688,7 +688,7 @@ function findError(el) {
   if (cdesc)
     desc = cdesc.text;
 
-  return new Error('UPnPError: ' + desc + ' (' + code + ')');
+  return new Error(`UPnPError: ${desc} (${code}).`);
 }
 
 /*