Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DialogueRunner parameter added to DialoguePresenterBase / DialogueViewBase #309

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

nrvllrgrs
Copy link
Contributor

  • Please check if the pull request fulfills these requirements
  • Tests for the changes have been added (for bug fixes / features)
    • Does it pass all existing unit tests without modification?
      • If not, what did you change?
      • If you altered it significantly, what coverage issue did you fix?
  • Docs have been added / updated (for bug fixes / features)
  • CHANGELOG.md has been updated to describe this change
  • What kind of change does this pull request introduce?
  • Bug Fix
  • Feature
  • Something else
  • What is the current behavior?

Fixed compiler error in Localization if USE_ADDRESSABLES is included -- where multiple GetLocalizedObjectAsync methods are defined.

  • What is the new behavior (if this is a feature change)?

DialogueRunner has been added as a parameter to the DialoguePresenterBase and DialogueViewBase. This allows users to more easily share the presenters and views between DialogueRunners. For example, if multiple runners are running simultaneously, the line presenter can determine which subtitles should be displayed based on player distance to runner or other criteria.

  • Does this pull request introduce a breaking change?

This change adds a DialogueRunner parameter to the DialoguePresenterBase and DialogueViewBase -- requiring users to update any extended classes.

  • Other information:

YarnProjectImporter.GenerateStringsTable() is public to match 2.5 behavior.

nrvllrgrs and others added 3 commits February 21, 2025 07:33
Changed GenerateStringTable from internal to public
Fixed Localization.GetLocalizedObjectSync if USE_ADDRESSABLES
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant