New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

end YarnTask.WaitUntil if CancellationToken is cancelled #304

Open

dogboydog wants to merge 2 commits into YarnSpinnerTool:development/v3 from dogboydog:yarntask-waituntil-canceltoken

dogboydog commented Jan 16, 2025 •

edited

Loading

Please check if the pull request fulfills these requirements

Tests for the changes have been added (for bug fixes / features)
- Does it pass all existing unit tests without modification?
  - If not, what did you change?
  - If you altered it significantly, what coverage issue did you fix?
Docs have been added / updated (for bug fixes / features)
CHANGELOG.md has been updated to describe this change

What kind of change does this pull request introduce?

Bug Fix
Feature
Something else

What is the current behavior?

The System.Threading.Tasks implementation of YarnTask.WaitUntil did not return early if the CancellationToken was canceled.

What is the new behavior (if this is a feature change)?
It will now return early as expected

Does this pull request introduce a breaking change?

Other information:


          end YarnTask.WaitUntil if CancellationToken is cancelled

c7b720b

dogboydog force-pushed the yarntask-waituntil-canceltoken branch from 8134c8d to c7b720b Compare

January 16, 2025 03:41


          link to PR in changelog for WaitUntil fix

fd1d6e8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet