Skip to content

Commit

Permalink
Support prefilled values for new objects (innogames#344)
Browse files Browse the repository at this point in the history
* Support prefilled values for new objects

Allow to specify values for attributes in the query string when creating
a new object.

* Update CHANGELOG.md
  • Loading branch information
kofrezo authored and YannikSc committed Apr 19, 2024
1 parent 0639bb3 commit 7247ccd
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 2 deletions.
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
# Change Log

## 4.12.1

* Support prefilled values via GET parameter for new objects [PR!344](https://github.com/innogames/serveradmin/pull/344)
7 changes: 5 additions & 2 deletions serveradmin/servershell/views.py
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ def edit(request):
return _edit(request, server, True)


def _edit(request, server, edit_mode=False, template='edit'): # NOQA: C901
def _edit(request: HttpRequest, server, edit_mode=False, template='edit'): # NOQA: C901
# @TODO work with ServerAttribute models here and use Django forms
invalid_attrs = set()
if edit_mode and request.POST:
Expand Down Expand Up @@ -346,6 +346,9 @@ def _edit(request, server, edit_mode=False, template='edit'): # NOQA: C901
):
continue

# Apply pre-filled values from query string if submitted
value = request.GET.get(key, value)

is_related_attribute = False
attribute = attribute_lookup[key]
servertype_attribute = servertype_attributes.get(key)
Expand Down Expand Up @@ -423,7 +426,7 @@ def commit(request):


@login_required
def new_object(request):
def new_object(request: HttpRequest):
servertype = request.GET.get('servertype')

try:
Expand Down

0 comments on commit 7247ccd

Please sign in to comment.