Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XXV_ETH Fix: Solve BSP generation bug for multiple subcores in the sa… #316

Open
wants to merge 257 commits into
base: master
Choose a base branch
from

Conversation

Imegahed
Copy link

@Imegahed Imegahed commented Oct 4, 2024

…me IP instance

Please do not submit a Pull Request via github. Our project makes use of mailing lists for patch submission and review. For more details please see https://xilinx-wiki.atlassian.net/wiki/spaces/A/pages/18842172/Create+and+Submit+a+Patch

Nandanikhil Gajulapally and others added 30 commits March 16, 2024 15:09
Update prints to use correct format specifier for 32bit variables

Signed-off-by: Nandanikhil Gajulapally <[email protected]>

Acked-for-series: Sreedhar Kundella <[email protected]>
Update prints to use correct format specifier for 32bit variables

Signed-off-by: Nandanikhil Gajulapally <[email protected]>

Acked-for-series: Sreedhar Kundella <[email protected]>
Edited the dependencies.prop to remove the import option for self_test example design.

Signed-off-by: nishantd <[email protected]>
1.Server support is added to send total frames in CRAM for a given
row in SSIT devices.
2.Cleared the SEM CRC and ECC errors in PMC_ERR2_STATUS Register
since HWEAM path to handle these errors is unused so
CFRAM_SEU_CRC/ECC bits are setting once boot done.

Signed-off-by: GayathriM <[email protected]>
To optimize MH signature, we have a circular dependency with IHT
signature(which is part of AC) while calculating MH signature(i.e., MH
Signature = RSA/ECDSA(SSK, SHA3(IHs, PHs, AC) || padding).
Fixed by removing IHT signature(which is part of AC) dependency for MH
signature calculation.
In case of Optimization, for MH hash calculation the authentication
Certificate will be (AC - IHT Signature).

Signed-off-by: Ankush Mehtre <[email protected]>
Acked-by: Bharath Mulagondla <[email protected]>
Modify pciepsu endpoint driver to support egress transfer.
Add required API's and example to support egress translation from PCIe
region to AXI.

Signed-off-by: Bhavana Jupalli <[email protected]>

Changes in V3:
Update CR number.

Changes in V2:
Revert the mdd file version due to patch rejection.
Parameter KeySrc can be passed as a structure member in AES client API
instead of a seperate argument. That redundancy is removed.

Signed-off-by: VSSLakshmiPrasanna.Vutukuri <[email protected]>
Acked-by: Harsha <[email protected]>
Update srec_bootloader and srec_spi_bootloader applications to support Microblaze RISC-V
processor.

Signed-off-by: Paul Alvin <[email protected]>
Acked-by: Srinivas Goud <[email protected]>
Fix the MISRA-C rule 4.7 violation.

Problem: Calling XPm_SubsystemIdleCores without checking return value.

Solution: Check the return value after calling a non-void function.

Signed-off-by: Jay Buddhabhatti <[email protected]>
Acked-by: Ronak Jain <[email protected]>
Fix doxygen warnings for trngpsv driver
and incremented library version to 1.5

Signed-off-by: Praveen Teja Kundanala <[email protected]>
Acked-by: Harsha <[email protected]>
Image selctor only check for persistant register for image selection
process but it does not have a validation check if boot bin really
exists in partition A or B of qspi flash offsets, this patch
addresses the issue by adding a validation check function.

Signed-off-by: Sharath Kumar Dasari <[email protected]>
Acked-by: Sreedhar Kundella <[email protected]>
…bedded applications

Update the lib dependencies based on xilstandalone instead of xiltimer.

Signed-off-by: Appana Durga Kedareswara rao <[email protected]>
Acked-by: Siva Durga Prasad Paladugu <[email protected]>
…ternal path

The external linker script can be configured using the USER_LINKER_SCRIPT
option/variable defined in the UserConfg.cmake. The default value of this
variable is $CMAKE_SOURCE_DIR/lscript.ld, but the template apps are not
using this variable. Update the template apps CMakeLists.txt to use this
variable.

Signed-off-by: Appana Durga Kedareswara rao <[email protected]>
Acked-by: Siva Durga Prasad Paladugu <[email protected]>
Add the support to split GPIO interrupts between multiple cpu cores.
With the current driver, a core will incorrectly clear an interrupt enabled
by another core because the driver does not handle which specific GPIOs are
masked to each core.
Add support to track which core enabled which GPIO interrupt and handles
the interrupts accordingly per cpu core.

Signed-off-by: Neal Frager <[email protected]>
Signed-off-by: Manikanta Guntupalli <[email protected]>
Acked-by: Srinivas Goud <[email protected]>
Provide the interrupt id from a array to XSetupInterruptSystem function.

Signed-off-by: Rajesh Gugulothu <[email protected]>

Acked-for-series: Gaddipati, Naveen <[email protected]>
Provide the interrupt id from a array to XSetupInterruptSystem
function.

Signed-off-by: Rajesh Gugulothu <[email protected]>

Acked-for-series: Gaddipati, Naveen <[email protected]>
C convention expects macros to be in all caps. To go with this, add versal
symbol to be all caps as well this define is missing in SDT flow.

Signed-off-by: Appana Durga Kedareswara rao <[email protected]>
Acked-by: Siva Durga Prasad Paladugu <[email protected]>
…n a function to support In-place PLM update

Moved initialization of HandlerTable of the IOModule instance and
XIOModule_BitPosMask array to XIOModule_HandlerTable_Initialize function
so that PLM can call this API to re-initialize them to default after
In-place PLM update where the driver and timer state are saved before
update is done and restored back when new PLM comes up.
This change is done to fix timestamp messup issue after In-place PLM
update.

Signed-off-by: Mounika Akula <[email protected]>

Acked-for-series: Bharath Mulagondla <[email protected]>
… PLM update

PLM timestamp is getting messed up after In-place PLM update as PLM is
writing the PIT counter values to its preload register. To fix this
issue, storing the IOModule instance before In-place update and skipping
the initialization of the IOModule driver.
Also, do not stop PIT3 timer during In-place PLM update.

Signed-off-by: Mounika Akula <[email protected]>

Acked-for-series: Bharath Mulagondla <[email protected]>
Change the format specifier to %08lx and add a cast UINTPTR for mac_baseaddr
to ensure proper printing.

Signed-off-by: Venkatesh Odela <[email protected]>
Acked-by: Harini Katakam <[email protected]>
Fixed doxygen warnings for xilloader

Signed-off-by: Harsha Harsha <[email protected]>
Acked-by: Bharath Mulagondla <[email protected]>
To reduce the IPI calls from linux to PLM(Xilsecure) for initializing the AES engine,
Added AES init call inside the AES operation init.

Signed-off-by: Mounika Botcha <[email protected]>
Acked-by: Kalyani Akula <[email protected]>
- In XPmNotifier_SendPendingNotifyEvent: A pointer should point to a const-qualified type whenever possible.

Signed-off-by: Trung tran <[email protected]>

Acked-for-series: Buddhabhatti, Jay <[email protected]>
- In XPm_Init: The precedence of operators within expressions should be made explicit.
- In AddPlDevice: Both operands of an operator in which the usual arithmetic conversions are performed shall have the same essential type category.
- In XPm_Init: Both operands of an operator in which the usual arithmetic conversions are performed shall have the same essential type category.
- In XPm_RequestHBMonDevice: The value of an expression shall not be assigned to an object with a narrower essential type or of a different essential type category.

Signed-off-by: Trung tran <[email protected]>

Acked-for-series: Buddhabhatti, Jay <[email protected]>
- MISRA rules 4.9: A function should be used in preference to a function-like macro where they are interchangeable.
- To fix this violation, we replace PIN_FUNC macro by the actual
  function call.

Signed-off-by: Trung tran <[email protected]>

Acked-for-series: Buddhabhatti, Jay <[email protected]>
- The prototype XPmRepair_Laguna_vp1902 should only exist when build for
  XCVP1902.

Signed-off-by: Trung tran <[email protected]>

Acked-for-series: Buddhabhatti, Jay <[email protected]>
- MISRA rule 10.5: The value of an expression should not be cast to an inappropriate essential type.
- Solution: replace TRUE by 1U and False by 0U values

Signed-off-by: Trung tran <[email protected]>

Acked-for-series: Buddhabhatti, Jay <[email protected]>
- Update the import example support for ZCU106 Rx only,
  vck190 pass through apps.

Signed-off-by: Katta Dhanunjanrao <[email protected]>
Acked-by: Gaddipati, Naveen <[email protected]>
Fixed yaml issues to support unified flow

Signed-off-by: Kunal Rane <[email protected]>

Acked-for-series: Gaddipati, Naveen <[email protected]>
Updated correct GPIO number for the ZCU102 app
as well as updated IRQ number for HDMI TX.

Signed-off-by: Kunal Rane <[email protected]>

Acked-for-series: Gaddipati, Naveen <[email protected]>
mubinsyed2 and others added 28 commits April 26, 2024 14:39
Many of the legacy BSP configuration options are deprecated
or not supported in SDT flow as of now. Existing BSP configuration
wizard is not displaying those options. Update cmake file to display
all such legacy options in BSP settings along with current
status (deprecated/not supported in current version).

Signed-off-by: Mubin Sayyed <[email protected]>
Acked-by: Appana Durga Kedareswara rao <[email protected]>
When a given re-configurable partition (PLDx) is loaded or reloaded, we
tear down its children partitions and release all the DDRMCs associated
with each child partition. However, the root partition is skipped during
teardown.  This results in PLM thinking that the root partition is
"active" during reload and errors out during PLDx <-> DDRMC linking.

Fix this by releasing the DDRMCs associated with the root PLDx node when
teardown happens for a given PLDx region.

In addition, We have DFx usecases where, the static image (base image
for PLD0), can include a "default RM" for a given RP. As an example, for
PLD0 -> PLD2 hierarchy, if PLD2 includes DDRMC2,3 then DDR modeling info
for them will be included in 2 images: inside PLD0 and inside PLD2:

In PLD0 image:

    PLD0 init_start
    ...
    pm_add_node PLD2
    pm_add_node_parent PLD2 PLD0
    pm_init_node PLD2 0xa <ddrmc2>
    pm_init_node PLD2 0xa <ddrmc3>
    ...
    PLD0 init_finish

In PLD2 RM (partial PDI):

    PLD2 init_start
    ...
    pm_init_node PLD2 0xa <ddrmc2>
    pm_init_node PLD2 0xa <ddrmc3>
    ...
    PLD2 init_finish

Until now, we expected the DDR modeling info for a given PLDx image to
be always present in its own image, but that's simply not the case.

Fix this by checking either current PLDx or one of its parents until
PLD0 are initializing before proceeding to execute this command.

Signed-off-by: Izhar Ameer Shaikh <[email protected]>
Acked-by: Madhav Bhatt <[email protected]>
Use XPLMI_SECURE_RSA_PRIVATE_DEC_KAT mask instead of
XPMI_SECURE_RSA_KAT_MASK

Signed-off-by: VSSLakshmiPrasanna.Vutukuri <[email protected]>
Acked-by: Durga Challa <[email protected]>
Fixed the error "Invalid escape sequence \N" by replacing the
paths backslash character with slash character.

Signed-off-by: Appana Durga Kedareswara rao <[email protected]>
Acked-by: Onkar Harsh <[email protected]>
Existing logic treats interrupts as SPI or PPI based on
bit number 20th encoded in interrupt ID, if said bit is not
set interrupt is always treated as SPI and offset 32 will be
added to interrupt ID. This is breaking software generated
interrupts.

Update logic to allocate bit 22 in encoded interrupt ID for
SGI interrupt, and modify offset calculation logic accordingly.
If bit 22 is set, offset added to interrupt id will be 0.

For configuring software generated interrupts, user needs to
use following APIs to get encoded parent intc base address and encoded
interrupt ID,

       XGetEncodedIntcBaseAddr
       XGetEncodedIntrId

Encoded parent intc base address and interrupt ID needs to be
passed to XSetupInterruptSystem.

Signed-off-by: Mubin Sayyed <[email protected]>

Acked-for-series: Siva Durga Prasad Paladugu <[email protected]>
Update xscugic_example to make use of interrupt wrapper
APIs for invoking SGI, when application is build in SDT flow.

Signed-off-by: Mubin Sayyed <[email protected]>

Acked-for-series: Siva Durga Prasad Paladugu <[email protected]>
GCC I/O functions like printf is calling open/close
syscalls, add open/close hook functions to support
GCC I/O functions.

Signed-off-by: Mubin Sayyed <[email protected]>
Acked-by: Appana Durga Kedareswara rao <[email protected]>
…rong DDR value in linker

Lately, the linear SPI flashes have been removed from TOTAL_MEM_CONTROLLERS list
to avoid getting their entries in the memory tests config structure. With this,
the length of TOTAL_MEM_CONTROLLER may become 1 when the design has BRAM and
axi_emc in it, triggering this unused legacy condition. This unwanted condition
is leading to setting of linker sections to BRAM which in principle is correct
but different than that of classic flow and is set using the wrong approach.

Remove this out of context DDR variable setting to avoid such unwanted behavior.

Signed-off-by: Onkar Harsh <[email protected]>
Acked-by: Siva Durga Prasad Paladugu <[email protected]>
by using default sleep timer as TTC0, leading to failures in
TTCPS examples also causing peripheral tests to fail. This is
because we exclusively use the TTC0 instance in every example.
Update TTC3 instance as the default sleep timer, to prevent
potential failure cases.

Signed-off-by: M Lakshmaiah <[email protected]>
Acked-by: Appana Durga Kedareswara rao <[email protected]>
Updated for openamp and libmetal

Signed-off-by: Kopparapu,Mounika <[email protected]>

Acked-by : Siva Addepalli<[email protected]>
Updated for xiltimer and cpu_cortex_r5

Signed-off-by: Kopparapu,Mounika <[email protected]>

Acked-by : Siva Addepalli<[email protected]>
The declaration for routines ScuGicSelfTestExample() and ScuGicInterruptSetup()
in scugic_header.h arent updated for SDT flow and this results in taking of
truncated baseaddress in SDT flow, hence correct the declarations for these
routines.

Signed-off-by: Siva Durga Prasad Paladugu <[email protected]>
Acked-by: Appana Durga Kedareswara rao <[email protected]>
update Embedded SW license 2024.1 release

Signed-off-by: Manikanta Sreeram <[email protected]>
Changelog updated with xilrsa

Signed-off-by: Kopparapu,Mounika <[email protected]>

Acked-by : Siva Addepalli<[email protected]>
This is a fix for versal secure lockdown LPD error.
Signed-off-by: Sangshetty Patil <[email protected]>

Acked-by:Trung Tran<[email protected]>
Added few more lines for xilloader

Signed-off-by: Kopparapu,Mounika <[email protected]>

Acked-by : Siva Addepalli<[email protected]>
The xlnx,switchable parameter in YAML should be xlnx,switchable-int.
Otherwise if the xlnx,switchable is present in the device tree as
"true" or "false" it will cause compilation issues.

Signed-off-by: Conall O'Griofa <[email protected]>
Acked-by: Appana Durga Kedareswara rao <[email protected]>
Updated changelogs for zynqmp_fsbl, zynqmp_pmufw, zynq_fsbl, imgsel
and img_rcvry apps

Signed-off-by: Sharath Kumar Dasari <[email protected]>
Acked-by: Sreedhar Kundella <[email protected]>
Update for dfemix, dfeccf, dfeequ, dfeofdm and dfeprach
changelog for 2024.1

Signed-off-by: Dragan Cvetic <[email protected]>

Acked-by : Siva Addepalli<[email protected]>
XRAM AXI-lite configuration is not supported in Vivado for VE2302 and VM1102
ES1 devices. Add a workaround to skip AXI-lite enablement on these devices.

Signed-off-by: Nicole Baze <[email protected]>

Acked-by:Trung Tran<[email protected]>
A lot of people are trying to send pull requests via github but this is not
the right channel to use. Linux project is doing review over emails that's
why use [email protected] if you want to contribute changes to this
repository.

Signed-off-by: Siva Addepalli <[email protected]>
@HariniKatakamX
Copy link
Contributor

Thanks for your pull request. Please note the previous comment for patch submission. In addition, this tcl is to be deprecated shortly as System Device Tree flow is now in use:
https://adaptivesupport.amd.com/s/article/Unlocking-the-Potential-of-the-System-Device-Tree-SDT-in-Vitis-Unified-IDE?language=en_US
https://github.com/Xilinx/system-device-tree-xlnx
We'll consider your fix in this flow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.