Fix clippy lints #743
Merged
Fix clippy lints #743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
joshka
commented
Dec 21, 2024
joshka
commented
- chore: remove unused imports
- chore: cargo clippy --fix
- chore: set MSRV to 1.73.0
- chore: allow upper case acronym for URI
- chore: allow projects module inception lint
- chore: Box the github error
Confirmed MSRV using `cargo-msrv find`
Required by the GraphQLQuery derive macro.
Clippy complains about this because the GithubError is relatively large. This makes that smaller by boxing the error source. See: <https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err>
|
Thank you for your PR, and congrats on your first contribution! 🎉 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.