-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix inconsistency and misinformation in gddocs #63
base: master
Are you sure you want to change the base?
Conversation
The Downloading Songs section should be ogg instead of mp3 to avoid confusion.
Add some minor changes
yeah yeah ncs
Btw, to make the ncs gauntelts "appear" from the server response you need to include the NCS gauntlets:BINARY_VERSION = 46
def get_raw_gauntlets(self, get21gauntlet=False) -> str:
'''
Return a list of raw Gauntlets
'''
data = {
"secret": COMMON_SECRET,
"special": 1,
"binaryVersion": BINARY_VERSION # Used for the NCS Gautlets (for some reasons)
}
if get21gauntlet:
data["special"] = 0
req = requests.post(ROOTURL + "database/getGJGauntlets21.php", data=data, headers=HEADERS)
return req.text without the NCS gauntlets:BINARY_VERSION = 46
def get_raw_gauntlets(self, get21gauntlet=False) -> str:
'''
Return a list of raw Gauntlets
'''
data = {
"secret": COMMON_SECRET,
"special": 1
}
if get21gauntlet:
data["special"] = 0
req = requests.post(ROOTURL + "database/getGJGauntlets21.php", data=data, headers=HEADERS)
return req.text |
Most of the changes look good, but please make separate PRs, one giant PR is difficult to review. Make one PR where you fix periods, other where you edit other general info etc. basically don't mix all the changes in a giant pr. Also revise which stuff has already been added (merge conflicts) |
Thanks |
The download link for the music library song is supposed to be .ogg not .mp3. I've changed it to avoid any other confusion.
I've also add some minor details in
resources/levels.md
and added NCS guantlets.And fixed getGJLevelLists.php mistaken as levels.