Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inconsistency and misinformation in gddocs #63

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

notanerd314
Copy link

@notanerd314 notanerd314 commented Oct 16, 2024

The download link for the music library song is supposed to be .ogg not .mp3. I've changed it to avoid any other confusion.
I've also add some minor details in resources/levels.md and added NCS guantlets.
And fixed getGJLevelLists.php mistaken as levels.

The Downloading Songs section should be ogg instead of mp3 to avoid confusion.
Add some minor changes
@notanerd314 notanerd314 marked this pull request as draft October 17, 2024 09:20
@notanerd314 notanerd314 marked this pull request as ready for review October 17, 2024 09:23
@notanerd314 notanerd314 marked this pull request as draft October 17, 2024 13:33
yeah yeah ncs
@notanerd314 notanerd314 marked this pull request as ready for review October 17, 2024 13:38
@notanerd314 notanerd314 marked this pull request as draft October 19, 2024 06:19
@notanerd314 notanerd314 changed the title Fix .mp3 and .ogg confusion in music_library.dat Fix inconsistency in gddocs Oct 19, 2024
@notanerd314 notanerd314 changed the title Fix inconsistency in gddocs Fix inconsistency and misinformation in gddocs Oct 19, 2024
@notanerd314 notanerd314 marked this pull request as ready for review October 19, 2024 06:23
@Geming400
Copy link

Geming400 commented Oct 26, 2024

Btw, to make the ncs gauntelts "appear" from the server response you need to include the BINARY_VERSION, I haven't checked if you need the 2.206's binary version or if it just accepts anything

NCS gauntlets:

BINARY_VERSION = 46
def get_raw_gauntlets(self, get21gauntlet=False) -> str:
    '''
    Return a list of raw Gauntlets
    '''
    data = {
"secret": COMMON_SECRET,
"special": 1,
"binaryVersion": BINARY_VERSION # Used for the NCS Gautlets (for some reasons)
}
    if get21gauntlet:
        data["special"] = 0
    
    req = requests.post(ROOTURL + "database/getGJGauntlets21.php", data=data, headers=HEADERS)
    return req.text

without the NCS gauntlets:

BINARY_VERSION = 46
def get_raw_gauntlets(self, get21gauntlet=False) -> str:
    '''
    Return a list of raw Gauntlets
    '''
    data = {
"secret": COMMON_SECRET,
"special": 1
}
    if get21gauntlet:
        data["special"] = 0
    
    req = requests.post(ROOTURL + "database/getGJGauntlets21.php", data=data, headers=HEADERS)
    return req.text

@notanerd314 notanerd314 marked this pull request as draft October 27, 2024 12:49
@notanerd314 notanerd314 marked this pull request as ready for review October 27, 2024 13:45
@notanerd314 notanerd314 marked this pull request as draft November 2, 2024 03:49
@notanerd314 notanerd314 marked this pull request as ready for review November 2, 2024 06:50
@iAndyHD3
Copy link
Collaborator

Most of the changes look good, but please make separate PRs, one giant PR is difficult to review. Make one PR where you fix periods, other where you edit other general info etc. basically don't mix all the changes in a giant pr. Also revise which stuff has already been added (merge conflicts)

@notanerd314
Copy link
Author

Most of the changes look good, but please make separate PRs, one giant PR is difficult to review. Make one PR where you fix periods, other where you edit other general info etc. basically don't mix all the changes in a giant pr. Also revise which stuff has already been added (merge conflicts)

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants