Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some style to align icons in notices. #70

Merged
merged 3 commits into from
Feb 28, 2023
Merged

Add some style to align icons in notices. #70

merged 3 commits into from
Feb 28, 2023

Conversation

StevenDufresne
Copy link
Contributor

@StevenDufresne StevenDufresne commented Feb 23, 2023 •
edited
Loading

I noticed that the icons in the message are not aligned.

This PR adds some CSS styles to align content in the <Notice> components. I'm not sure if this is in the right place, advise if there is a better place to add this code (or a different approach).

ScreenShots

Before After Mobile
Screen Shot 2566-02-23 at 11 46 55 Screen Shot 2566-02-23 at 12 34 35 Screen Shot 2566-02-23 at 12 31 16
Screen Shot 2566-02-23 at 11 46 46 Screen Shot 2566-02-23 at 12 34 43 Screen Shot 2566-02-23 at 12 31 11
Screen Shot 2566-02-23 at 12 20 16 Screen Shot 2566-02-23 at 12 34 54 Screen Shot 2566-02-23 at 12 30 57

No Icon

Screen Shot 2566-02-23 at 12 41 25

@StevenDufresne StevenDufresne marked this pull request as ready for review February 23, 2023 03:42
dd32
dd32 approved these changes Feb 24, 2023
View reviewed changes
Copy link
Member

@dd32 dd32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, and seems like a reasonably generic place to have it.

iandunn
iandunn approved these changes Feb 24, 2023
View reviewed changes
Copy link
Member

@iandunn iandunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@iandunn iandunn added this to the Iteration 1 milestone Feb 24, 2023
@iandunn
Copy link
Member

iandunn commented Feb 24, 2023

This partially fixes the design for callout boxes styles 👍🏻

@StevenDufresne StevenDufresne merged commit ac00418 into trunk Feb 28, 2023
@StevenDufresne StevenDufresne deleted the fix/arrow-alignment branch February 28, 2023 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dd32 dd32 dd32 approved these changes

@iandunn iandunn iandunn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Iteration 1
Development

Successfully merging this pull request may close these issues.
3 participants
@StevenDufresne @iandunn @dd32