-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add handbook meta link block #558
Conversation
Could this be called something more generic? Or is it really necessary as a block? It's just a label + link text, not directly related to site or post meta values, or github. Oh, I see the screen reader text now, and the history in WordPress/wporg-developer#388. It's a bummer we need to create a whole block too have that kind of workaround. Maybe Aside from that feedback, the PRs do work as-is. I am seeing the changelog/improve this links on code reference pages (like https://developer.wordpress.org/reference/functions/block_has_support/), but I think that's true on production to. Is that intentional? |
No, looks like a regression 😞 The designs show no meta info at all on code reference. |
This issue has already been fixed by WordPress/wporg-developer#472. For this PR, it works as described together with WordPress/wporg-developer#470. 👍
It looks like a good idea. Like in the case of the developer, there is this logic determining if a link is a GitHub link. So we might be able to remove the specific mention of GitHub to make it more generic here. |
Alright, I renamed this to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested again and looks good to me.
This PR is a follow-up to WordPress/wporg-developer#454.
This block is showing up in multiple different themes. This one for example.
Example usage
Using
IMPORTANT
This needs to be merged & deployed together with WordPress/wporg-developer#470.