Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add handbook meta link block #558

Merged
merged 6 commits into from
Jan 22, 2024
Merged

Add handbook meta link block #558

merged 6 commits into from
Jan 22, 2024

Conversation

StevenDufresne
Copy link
Contributor

@StevenDufresne StevenDufresne commented Jan 15, 2024

This PR is a follow-up to WordPress/wporg-developer#454.

This block is showing up in multiple different themes. This one for example.

Example usage

Using

<!-- wp:wporg/handbook-meta-link {"heading":"Edit article","linkURL":"//wp.org","linkText":"Improve it on GitHub"} /-->

IMPORTANT

This needs to be merged & deployed together with WordPress/wporg-developer#470.

@ryelle
Copy link
Contributor

ryelle commented Jan 15, 2024

Could this be called something more generic? Or is it really necessary as a block? It's just a label + link text, not directly related to site or post meta values, or github. wporg/label-with-link?

Oh, I see the screen reader text now, and the history in WordPress/wporg-developer#388. It's a bummer we need to create a whole block too have that kind of workaround.

Maybe wporg/handbook-link? Though if you do that, you'll want to update filter_article_meta_block in developer too.

Aside from that feedback, the PRs do work as-is.

I am seeing the changelog/improve this links on code reference pages (like https://developer.wordpress.org/reference/functions/block_has_support/), but I think that's true on production to. Is that intentional?
Screenshot 2024-01-15 at 5 22 58 PM

@adamwoodnz
Copy link
Contributor

adamwoodnz commented Jan 15, 2024

I am seeing the changelog/improve this links on code reference pages (like https://developer.wordpress.org/reference/functions/block_has_support/), but I think that's true on production to. Is that intentional?

No, looks like a regression 😞

The designs show no meta info at all on code reference.

@renintw
Copy link
Contributor

renintw commented Jan 22, 2024

I am seeing the changelog/improve this links on code reference pages (like https://developer.wordpress.org/reference/functions/block_has_support/), but I think that's true on production to. Is that intentional?

This issue has already been fixed by WordPress/wporg-developer#472.

For this PR, it works as described together with WordPress/wporg-developer#470. 👍

Maybe wporg/handbook-link

It looks like a good idea. Like in the case of the developer, there is this logic determining if a link is a GitHub link. So we might be able to remove the specific mention of GitHub to make it more generic here.

@StevenDufresne StevenDufresne changed the title Add/article meta block Add handbook meta link block Jan 22, 2024
@StevenDufresne
Copy link
Contributor Author

Alright, I renamed this to wporg/handbook-meta-link and updated the developer PR to match: WordPress/wporg-developer#470

Copy link
Contributor

@renintw renintw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested again and looks good to me.

@StevenDufresne StevenDufresne merged commit 972987e into trunk Jan 22, 2024
2 checks passed
@StevenDufresne StevenDufresne deleted the add/article-meta-block branch January 22, 2024 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants