Remove live-check of the canHideOnlineStatus permission
#6148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The live check means that the user's group assignments and permissions had to be loaded. This is particularly unfavorable in places where many users are displayed (such as the member list).
The new method checks whether a user has restricted the visibility of their online status in the past, but has since lost the permission for it. In this case, the visibility of the online status is automatically set to default.
dtdesign
requested changes
Dec 20, 2024
wcfsetup/install/files/lib/system/worker/UserRebuildDataWorker.class.php
Outdated
Show resolved
Hide resolved
wcfsetup/install/files/lib/system/worker/UserRebuildDataWorker.class.php
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The live check means that the user's group assignments and permissions had to be loaded. This is particularly unfavorable in places where many users are displayed (such as the member list).