patterns/ani: Improved compatibility with error size defined in ani files #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the process of learning
pattern-language, I selected ani.hexpat file with relatively little content for testing and learning. At that time, I did not use the test data ani.hexpat.ani in this repo, but found a 1718926927_SizeAll.ani on the Internet, that is, renamed ani.compatibility.hexpat.ani in PR.Use ani.hexpat to evaluate ani.compatibility.hexpat.ani and console output error, then check and find that the size defined by
u32 @0x04in file -ani.compatibility.hexpat.ani- is incorrect. However, other software such as open-ani-online- can parse this ani file online, so the pattern file is modified to be compatible with the incorrectly defined size of the ani file format.