Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign HomePage #21

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Redesign HomePage #21

wants to merge 1 commit into from

Conversation

i-faraz
Copy link

@i-faraz i-faraz commented Oct 1, 2022

  • Add Responsive Header
  • Develop Hero Box
  • Redesign Cards

@farnoodma
Copy link
Member

@i-faraz hey! I really like what you did with the UI. However, I believe the initial idea was to have an overview of the wall and see the percentage of green and reds with your eyes. That's why @firiz added the zoom in and out buttons so you can zoom out and see the whole picture. Can we somehow migrate that feature to this new design?
The only problem that I see is that when you are zooming out, it will be hard to see the border colors of cards, maybe we can handle this by switching to background if cards are too small. What do you think?

@i-faraz
Copy link
Author

i-faraz commented Oct 2, 2022

Hey @farnoodma
ok so i add zoom control to this design and i make Border-Size Dynamic by changing zoom
is it ok?

@i-faraz
Copy link
Author

i-faraz commented Oct 2, 2022

Screen Shot 1401-07-10 at 8 21 49 PM

@farnoodma

@mehdi-ra
Copy link
Contributor

mehdi-ra commented Oct 2, 2022

Is ain't no better to have just two static viewports instead of zooming out or zooming in? One for the whole picture and the other for a standard view? I think this is more user-friendly to have it by toggling with one button instead of zooming in and zooming out.

@i-faraz
Copy link
Author

i-faraz commented Oct 2, 2022

Screen Shot 1401-07-11 at 1 04 05 AM

@me-dira What do you think about this?

@mehdi-ra
Copy link
Contributor

mehdi-ra commented Oct 3, 2022

I like it but it's better to discuss it with others.
@i-faraz

@farnoodma
Copy link
Member

Still, it is not very clean. Just to be on the same page: what was the problem with having pictures in red, green, and gray?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants