Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CICD Tools Plugin to UI #396

Merged
merged 18 commits into from
Jan 6, 2025
Merged

Add CICD Tools Plugin to UI #396

merged 18 commits into from
Jan 6, 2025

Conversation

g-marconet
Copy link
Contributor

@g-marconet g-marconet commented Dec 18, 2024

Adds CICD Tools Plugin to UI

NOTE: Will not merge until the new year

Description

Changes in 3 places:

  • Added as option to "Inventory" dropdown
  • Added as result in "Inventory" tab of Results page
  • Added as a filter option on Repository tab of Search page
    • Creates a new dropdown component
      • Only "exact" matches work with key lookups and the exact matches would have to be with an un-intuitive ID we define. Because of this, a dropdown leads to the best user experience

Inventory dropdown:

Screenshot 2024-12-18 at 10 49 01 AM

Inventory tab of Results page

No results

Screenshot 2024-12-18 at 11 24 22 AM

Results

Screenshot 2024-12-18 at 10 48 50 AM

Repository tab of Search Page

On first load

Screenshot 2024-12-18 at 10 43 23 AM

Dropdown

Screenshot 2024-12-18 at 10 43 31 AM

Selected

Screenshot 2024-12-18 at 10 43 42 AM

Motivation and Context

  • These features have been enabled API side for a bit, but we haven't exposed them as of yet

How Has This Been Tested?

  • Tests pass
  • Working in dev environment

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation change

Checklist

  • My code follows conforms to the coding standards.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@g-marconet g-marconet marked this pull request as ready for review December 18, 2024 20:02
@g-marconet g-marconet requested a review from a team as a code owner December 18, 2024 20:02
@g-marconet g-marconet merged commit 42fc7fb into main Jan 6, 2025
6 checks passed
@g-marconet g-marconet deleted the g-marconet/cicd-ui branch January 6, 2025 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants