Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a single Lambda Layer for Artemis & Heimdall packages #245

Merged
merged 12 commits into from
Aug 23, 2024

Conversation

Kamsiy
Copy link
Contributor

@Kamsiy Kamsiy commented Aug 22, 2024

Description

The dependencies for Artemis & Heimdall lambdas are defined in multiple locations. This setup makes it difficult to maintain consistent dependencies across all Lambdas.

This PR updates the Makefile to generate two Lambda layers, artemis-backend-core and heimdall-core for Artemis and Heimdall Lambdas.

artemis-core contents:

  • artemislib
  • artemisdb
  • artemisapi
  • packages in backend/Pipfile

heimdall-core contents:

  • heimdall_utils
  • heimdall_repos
  • heimdall_orgs
  • packages in orchestrator/Pipfile

Moving forward, the dependencies for Heimdall or Artemis Lambdas will be managed by the Pipfiles

  • For Artemis Lambdas the Lambda dependencies can be modified in backend/Pipfile
  • For Heimdall Lambdas the Lambda dependencies can be modified in orchestrator/Pip

Motivation and Context

How Has This Been Tested?

tested in a dev environment

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation change

Checklist

  • My code follows conforms to the coding standards.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@Kamsiy Kamsiy marked this pull request as ready for review August 23, 2024 05:13
@Kamsiy Kamsiy requested a review from a team as a code owner August 23, 2024 05:13
@Kamsiy Kamsiy requested a review from mdfleury-wbd August 23, 2024 14:57
@Kamsiy Kamsiy requested a review from ZoogieZork August 23, 2024 15:37
@Kamsiy Kamsiy added this pull request to the merge queue Aug 23, 2024
Merged via the queue into main with commit e55711c Aug 23, 2024
6 checks passed
@Kamsiy Kamsiy deleted the lambda-layers branch August 26, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants