-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a single Lambda Layer for Artemis & Heimdall packages #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
ZoogieZork
requested changes
Aug 23, 2024
ZoogieZork
approved these changes
Aug 23, 2024
mdfleury-wbd
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The dependencies for Artemis & Heimdall lambdas are defined in multiple locations. This setup makes it difficult to maintain consistent dependencies across all Lambdas.
This PR updates the Makefile to generate two Lambda layers,
artemis-backend-core
andheimdall-core
for Artemis and Heimdall Lambdas.artemis-core
contents:artemislib
artemisdb
artemisapi
backend/Pipfile
heimdall-core
contents:heimdall_utils
heimdall_repos
heimdall_orgs
orchestrator/Pipfile
Moving forward, the dependencies for Heimdall or Artemis Lambdas will be managed by the Pipfiles
backend/Pipfile
orchestrator/Pip
Motivation and Context
How Has This Been Tested?
tested in a dev environment
Types of changes
Checklist