Adding gitlab repo health monitor #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdfleury-wbd
changed the title
mdfleury-wbd
commented
Aug 27, 2024
| @@ -102,7 +102,7 @@ def test_override_check_description(self): | |||
| BranchProtectionStatusChecks.check(mock_github, OWNER, REPO, BRANCH, config), | |||
| ) | |||
|
|
|||
| def test_no_required_status_checks(self): | |||
| def test_single_required_status_checks(self): | |||
There was a problem hiding this comment.
There's already another test with this name.
mdfleury-wbd
commented
Aug 27, 2024
| @@ -307,6 +307,10 @@ endef | |||
| test-deps: get-shell-check get-detekt get-mock-swiftlint get-trivy install-plugin-dependencies | |||
| .PHONY: test-deps | |||
|
|
|||
| unit-test-no-deps: | |||
There was a problem hiding this comment.
I use this locally, its been pretty useful.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
mdfleury-wbd
commented
Sep 10, 2024
| @@ -611,13 +611,13 @@ def get_plugin_command(scan, image, plugin, depth, include_dev, scan_images, plu | |||
| "-e", | |||
| f"APPLICATION={APPLICATION}", | |||
| "-e", | |||
| f"ARTEMIS_REV_PROXY_DOMAIN_SUBSTRING={REV_PROXY_DOMAIN_SUBSTRING}", | |||
There was a problem hiding this comment.
Changing these to the correct env var names.
mdfleury-wbd
commented
Sep 10, 2024
| @@ -640,6 +640,10 @@ def get_plugin_command(scan, image, plugin, depth, include_dev, scan_images, plu | |||
| "-e", | |||
| f"ARTEMIS_GITHUB_APP_ID={GITHUB_APP_ID}", | |||
| "-e", | |||
| f"ARTEMIS_REVPROXY_DOMAIN_SUBSTRING={REV_PROXY_DOMAIN_SUBSTRING}", | |||
| "-e", | |||
| f"ARTEMIS_REVPROXY_SECRET={REV_PROXY_SECRET}", | |||
There was a problem hiding this comment.
This is the location of the secret in secrets manager, not the actual secret.
…Media/artemis into adding-gitlab-repo-health
g-marconet
reviewed
Sep 10, 2024
g-marconet
reviewed
Sep 10, 2024
g-marconet
reviewed
Sep 10, 2024
g-marconet
reviewed
Sep 10, 2024
g-marconet
reviewed
Sep 10, 2024
g-marconet
reviewed
Sep 10, 2024
g-marconet
reviewed
Sep 10, 2024
...plugins/gitlab_repo_health/rules/first_order_rules/branch_protection_prevent_secret_files.py
Show resolved
Hide resolved
g-marconet
reviewed
Sep 10, 2024
g-marconet
reviewed
Sep 10, 2024
backend/engine/plugins/gitlab_repo_health/rules/first_order_rules/__init__.py
Outdated
Show resolved
Hide resolved
g-marconet
reviewed
Sep 10, 2024
g-marconet
reviewed
Sep 10, 2024
...engine/plugins/gitlab_repo_health/rules/first_order_rules/branch_protection_pull_requests.py
Show resolved
Hide resolved
g-marconet
reviewed
Sep 10, 2024
...engine/plugins/gitlab_repo_health/rules/first_order_rules/branch_protection_pull_requests.py
Show resolved
Hide resolved
g-marconet
reviewed
Sep 10, 2024
| branch_rules = [] | ||
| for rule in approval_rules: | ||
| for each_branch in rule.get("protected_branches"): | ||
| if (each_branch.get("name")) == branch: |
There was a problem hiding this comment.
Does gitlab support any sort of pattern matching for rules? This sort of logic has led to bugs in GHRC due to not processing pattern matching locally
There was a problem hiding this comment.
They do not, unfortunately.
There was a problem hiding this comment.
I realized this is actually fortunately, not unfortunately.
g-marconet
reviewed
Sep 10, 2024
...engine/plugins/gitlab_repo_health/rules/first_order_rules/branch_protection_pull_requests.py
Outdated
Show resolved
Hide resolved
g-marconet
reviewed
Sep 10, 2024
ZoogieZork
requested changes
Sep 10, 2024
ZoogieZork
previously approved these changes
Sep 11, 2024
There was a problem hiding this comment.
Looks good from my end; I'll let @g-marconet evaluate on his end.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding Gitlab repo health plugin
Motivation and Context
We want to be able to check the configuration status of Gitlab repos
How Has This Been Tested?
Tested in nonprod
Types of changes
Checklist