Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Set A Cookie Algorithm #231

Merged
merged 4 commits into from
Jun 7, 2024
Merged

Fix Set A Cookie Algorithm #231

merged 4 commits into from
Jun 7, 2024

Conversation

ayuishii
Copy link
Collaborator

@ayuishii ayuishii commented Jun 7, 2024 •
edited by pr-preview bot
Loading

Addresses issue: #227

  • Updates "Set a Cookie" algorithm to not null check path as it should always be populated
  • Updates set method to call algorithm with all non-optional parameters

Preview | Diff

@ayuishii ayuishii requested a review from inexorabletash June 7, 2024 20:17
@inexorabletash
Copy link
Member 

    $ bikeshed --die-on=fatal spec "index.bs" "index.bs.built.html" 
      LINE ~1271: Couldn't find section '#section-5.7.3' in spec 'rfc6265bis':
      [[RFC6265bis#section-5.7.3]]
       ✘  Did not generate, due to errors exceeding the allowed error level.
    Command `bikeshed --die-on=fatal spec "index.bs" "index.bs.built.html" ` failed with exit code: 2.

Unfortunately the RFC renumbered things. Fortunately Bikeshed actually catches this now, which is awesome. I think I made a local PR to update the numbers a while ago, which may or may not still be valid. Let me take a look...

inexorabletash
inexorabletash approved these changes Jun 7, 2024
View reviewed changes
Copy link
Member

@inexorabletash inexorabletash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, pending link fixes.

@inexorabletash
Copy link
Member

Ah, the latest rfc6265bis has named anchors. Let me see if I can get a PR together quickly...

inexorabletash
inexorabletash reviewed Jun 7, 2024
View reviewed changes
index.bs Outdated Show resolved Hide resolved
@ayuishii
Copy link
Collaborator Author

ayuishii commented Jun 7, 2024

Wohoo, passed! Thanks @inexorabletash !

@ayuishii ayuishii merged commit dda009f into WICG:main Jun 7, 2024
2 checks passed
@ayuishii ayuishii deleted the set-a-cookie branch June 7, 2024 23:57
github-actions bot added a commit that referenced this pull request Jun 7, 2024
@ayuishii @github-actions
Fix Set A Cookie Algorithm (#231)
4211c63 
SHA: dda009f
Reason: push, by ayuishii

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inexorabletash inexorabletash inexorabletash approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ayuishii @inexorabletash