feat: Reimplement webhooks for Voice API #506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #506 +/- ##
============================================
- Coverage 94.22% 94.19% -0.03%
- Complexity 2797 2854 +57
============================================
Files 405 413 +8
Lines 6748 6842 +94
Branches 444 445 +1
============================================
+ Hits 6358 6445 +87
- Misses 203 204 +1
- Partials 187 193 +6
|
SMadani
force-pushed
the
voice-webhooks
branch
5 times, most recently
from
40dc5d3 to
91e6769
Compare
SMadani
force-pushed
the
voice-webhooks
branch
from
91e6769 to
1dd6d63
Compare
SMadani
force-pushed
the
voice-webhooks
branch
from
3854fcf to
2ec065a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of webhooks for Voice in the
com.vonage.client.incoming.*package is incomplete as described in #475. Furthermore, it requires a priori knowledge of the event type, which further devalues the classes since some form of parsing is needed to determine the correct class to map the JSON payload to. This PR aims to follow the same approach as the implementations for Messages and Verify v2: use a single class for each inbound URL. That way, the user can simply call thefromJsonmethod on a single class based on which URL is hit, and obtain the relevant fields based on the event type.