Skip to content

Commit

Permalink
feat: make RealTimeData obsolete in NI
Browse files Browse the repository at this point in the history
  • Loading branch information
Tr00d committed Jan 14, 2025
1 parent cf5f12c commit 7f6c25f
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 3 deletions.
8 changes: 6 additions & 2 deletions Vonage/NumberInsights/AdvancedInsightsResponse.cs
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
#region
using System;
using Newtonsoft.Json;
using Newtonsoft.Json.Converters;
#endregion

namespace Vonage.NumberInsights;

Expand All @@ -8,13 +11,13 @@ public class AdvancedInsightsResponse : StandardInsightResponse
/// <summary>
/// Shows if all information about a phone number has been returned.
/// </summary>
[JsonProperty("lookup_outcome")]
[JsonProperty("lookup_outcome")]
public int LookupOutcome { get; set; }

/// <summary>
/// Shows if all information about a phone number has been returned.
/// </summary>
[JsonProperty("lookup_outcome_message")]
[JsonProperty("lookup_outcome_message")]
public string LookupOutcomeMessage { get; set; }

/// <summary>
Expand All @@ -40,5 +43,6 @@ public class AdvancedInsightsResponse : StandardInsightResponse
/// Real time data about the number
/// </summary>
[JsonProperty("real_time_data")]
[Obsolete("Redundant property as functionality already covered by ValidNumber and Reachable.")]
public RealTimeData RealTimeData { get; set; }
}
7 changes: 6 additions & 1 deletion Vonage/NumberInsights/AdvancedNumberInsightRequest.cs
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
#region
using System;
using Newtonsoft.Json;
#endregion

namespace Vonage.NumberInsights;

Expand All @@ -10,5 +13,7 @@ public class AdvancedNumberInsightRequest : StandardNumberInsightRequest
[JsonProperty("ip")]
public string Ip { get; set; }

[JsonProperty("real_time_data")] public bool RealTimeData { get; set; }
[JsonProperty("real_time_data")]
[Obsolete("Redundant property.")]
public bool RealTimeData { get; set; }
}

0 comments on commit 7f6c25f

Please sign in to comment.