mute all #1
Open
mute all #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OmriShraga
requested review from
elishaikatz,
keichenblat,
mbenarie,
tamir-moualem and
TamirVonage
keichenblat
approved these changes
Nov 8, 2020
tamir-moualem
approved these changes
Nov 8, 2020
elishaikatz
reviewed
Nov 8, 2020
elishaikatz
reviewed
Nov 11, 2020
jeffswartz
suggested changes
Mar 23, 2021
Comment on lines
+810
to
+811
| * @param callback {Function} The function to call upon completing the operation. Two arguments | ||
| * are passed to the function: |
| @@ -420,6 +420,37 @@ opentok.forceDisconnect(sessionId, connectionId, function (error) { | |||
| This is the server-side equivalent to the forceDisconnect() method in OpenTok.js: | |||
| <https://www.tokbox.com/developer/guides/moderation/js/#force_disconnect>. | |||
|
|
|||
| ### Force Mute a participant | |||
There was a problem hiding this comment.
Suggested change
| ### Force Mute a participant | |
| ### Force a publisher to mute audio |
jeffswartz
suggested changes
Mar 23, 2021
There was a problem hiding this comment.
I added a PR to this PR to add docs edits: #2. @OmriShraga , please review and merge in if it looks good. (I was not able to commit directly to your PR.)
jeffswartz
suggested changes
Mar 23, 2021
Comment on lines
+834
to
+835
| * @param callback {Function} The function to call upon completing the operation. Two arguments | ||
| * are passed to the function: |
jeffswartz
suggested changes
Mar 23, 2021
| }, callback); | ||
| }; | ||
|
|
||
| handleForceMute = function (config, sessionId, streamId, excludedStreamIds = null, callback) { |
There was a problem hiding this comment.
Linting error here. The codebase is not using ES6 (and default parameters). And there are other linting errors. Please run npm run lint.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added force mute and force mute all