Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IrcColors plugin #2048

Merged
merged 27 commits into from
Jan 27, 2025
Merged

Add IrcColors plugin #2048

merged 27 commits into from
Jan 27, 2025

Conversation

jedenastka
Copy link
Contributor

@jedenastka jedenastka commented Dec 11, 2023

The plugin generates unique colors for usernames in chat, similar to how it works in many IRC clients.

Chat with Compact++ and IrcColors enabled

@jedenastka jedenastka changed the base branch from main to dev December 22, 2023 18:31
The plugin generates unique colors for usernames in chat, similar to how
it works in many IRC clients.
@Vendicated Vendicated force-pushed the dev branch 2 times, most recently from 42307cc to 4a1c85c Compare January 5, 2024 21:06
Sync with dev.

Ven no like rebase 😭
@jedenastka
Copy link
Contributor Author

This is a very good MR please review

src/plugins/ircColors/index.ts Outdated Show resolved Hide resolved
src/plugins/ircColors/index.ts Outdated Show resolved Hide resolved
@Vendicated Vendicated force-pushed the dev branch 2 times, most recently from bc885f9 to da50c7a Compare February 28, 2024 19:25
@Vendicated Vendicated dismissed their stale review March 13, 2024 21:38

resolved

@Vendicated
Copy link
Owner

Please add a README.md file with a screenshot

@Vendicated
Copy link
Owner

its a bit weird that this doesn't affect the member list

@Vendicated Vendicated marked this pull request as draft March 22, 2024 01:22
@Vendicated Vendicated force-pushed the dev branch 2 times, most recently from 3a25da5 to 05a4044 Compare May 30, 2024 21:33
@Nuckyz Nuckyz force-pushed the dev branch 2 times, most recently from c50208b to d8524b0 Compare June 1, 2024 21:40
Copy link
Owner

@Vendicated Vendicated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for the most part so this can definitely be merged once these minor things are fixed

src/plugins/ircColors/index.ts Outdated Show resolved Hide resolved
src/plugins/ircColors/index.ts Outdated Show resolved Hide resolved
src/plugins/ircColors/index.ts Outdated Show resolved Hide resolved
src/plugins/ircColors/README.md Show resolved Hide resolved
src/plugins/ircColors/index.ts Outdated Show resolved Hide resolved
src/plugins/fixCodeblockGap/README.md Outdated Show resolved Hide resolved
@Nuckyz Nuckyz force-pushed the dev branch 9 times, most recently from fa092cf to eb63a54 Compare September 23, 2024 16:25
@Vendicated
Copy link
Owner

there's actually one bug I noticed: for people who use the colour dot instead of role name (or use BetterRoleDot), the roledot has the wrong colour

image

also this doesn't integrate with RoleColorEverywhere which kinda sucks and should be added

image

In any case, I will just merge this now and we can make these fixes later

@Vendicated Vendicated merged commit cf28c65 into Vendicated:dev Jan 27, 2025
1 check passed
@jedenastka
Copy link
Contributor Author

jedenastka commented Jan 29, 2025

Thanks for the merge!

there's actually one bug I noticed: for people who use the colour dot instead of role name (or use BetterRoleDot), the roledot has the wrong colour

I think I already said this on Discord (a year ago, when I initially created the branch lol), but I don't really see value in having the role dot on while having the plugin enabled. Really, I considered patching out the dot completely, but decided against it because it's an additional patch that requires work (lazy) and it doesn't really hurt anybody (maybe someone wants to still see the role color as well, in which case they can use this combination (I don't see this being used by anyone but still)).

also this doesn't integrate with RoleColorEverywhere which kinda sucks and should be added

Agree. This is pure laziness on my part, I would probably use RoleColorEverywhere if it was integrated. Will work on this when I have time, I should probably fix #2061 first though.

DDbrother9999 pushed a commit to DDbrother9999/Vencord that referenced this pull request Jan 30, 2025
nin0-dev pushed a commit to nin0-dev/Ninacord that referenced this pull request Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants