-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add IrcColors plugin #2048
Add IrcColors plugin #2048
Conversation
166f982
to
4cccd39
Compare
The plugin generates unique colors for usernames in chat, similar to how it works in many IRC clients.
4cccd39
to
9605dab
Compare
42307cc
to
4a1c85c
Compare
Sync with dev. Ven no like rebase 😭
This is a very good MR please review |
bc885f9
to
da50c7a
Compare
Please add a README.md file with a screenshot |
its a bit weird that this doesn't affect the member list |
3a25da5
to
05a4044
Compare
c50208b
to
d8524b0
Compare
bc67db1
to
b333deb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for the most part so this can definitely be merged once these minor things are fixed
fa092cf
to
eb63a54
Compare
there's actually one bug I noticed: for people who use the colour dot instead of role name (or use BetterRoleDot), the roledot has the wrong colour also this doesn't integrate with RoleColorEverywhere which kinda sucks and should be added In any case, I will just merge this now and we can make these fixes later |
Thanks for the merge!
I think I already said this on Discord (a year ago, when I initially created the branch lol), but I don't really see value in having the role dot on while having the plugin enabled. Really, I considered patching out the dot completely, but decided against it because it's an additional patch that requires work (lazy) and it doesn't really hurt anybody (maybe someone wants to still see the role color as well, in which case they can use this combination (I don't see this being used by anyone but still)).
Agree. This is pure laziness on my part, I would probably use RoleColorEverywhere if it was integrated. Will work on this when I have time, I should probably fix #2061 first though. |
Co-authored-by: V <[email protected]>
Co-authored-by: V <[email protected]>
The plugin generates unique colors for usernames in chat, similar to how it works in many IRC clients.