Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Porting add_param and rm_globalevent #47

Merged
merged 3 commits into from
Nov 19, 2024
Merged

Porting add_param and rm_globalevent #47

merged 3 commits into from
Nov 19, 2024

Conversation

gvegayon
Copy link
Member

This pull request includes several changes to improve the functionality and documentation of the epiworld package. The most notable changes involve the addition of new methods for handling parameters and the renaming of global actions to global events.

Key Changes:

New Methods for Handling Parameters:

  • Added add_param and add_param_cpp functions to allow adding parameters to models. (R/cpp11.R, R/model-methods.R, src/cpp11.cpp, src/model.cpp) [1] [2] [3] [4] [5] [6]
  • Updated the NAMESPACE file to export the new add_param method. (NAMESPACE) [1] [2]

Renaming Global Actions to Global Events:

  • Renamed all references of "global actions" to "global events" in the documentation and function names to better reflect their purpose. (R/global-actions.R, man/global-events.Rd) [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12]

These changes enhance the functionality of the epiworld package by adding new methods for parameter handling and improving the clarity of global event-related functions.

@gvegayon gvegayon requested a review from apulsipher November 19, 2024 16:35
Copy link
Contributor

@apulsipher apulsipher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@apulsipher apulsipher merged commit bf4b679 into main Nov 19, 2024
12 of 13 checks passed
@apulsipher apulsipher deleted the patch-events-param branch November 19, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants